You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/18 13:10:10 UTC
[GitHub] [pulsar] codelipenghui opened a new pull request #8613: Support enable WebSocket on Pulsar Proxy.
codelipenghui opened a new pull request #8613:
URL: https://github.com/apache/pulsar/pull/8613
### Motivation
Support enable WebSocket on Pulsar Proxy.
### Verifying this change
Integration tests added.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
- Does this pull request introduce a new feature? (no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on a change in pull request #8613: Support enable WebSocket on Pulsar Proxy.
Posted by GitBox <gi...@apache.org>.
sijie commented on a change in pull request #8613:
URL: https://github.com/apache/pulsar/pull/8613#discussion_r526579808
##########
File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java
##########
@@ -528,6 +530,20 @@
)
}
)
+
+ /***** --- WebSocket --- ****/
+ @FieldContext(
+ category = CATEGORY_WEBSOCKET,
+ doc = "The directory to locate WebSocket servlet"
Review comment:
The documentation here is wrong?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8613: Support enable WebSocket on Pulsar Proxy.
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8613:
URL: https://github.com/apache/pulsar/pull/8613#issuecomment-730715615
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #8613: Support enable WebSocket on Pulsar Proxy.
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #8613:
URL: https://github.com/apache/pulsar/pull/8613
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8613: Support enable WebSocket on Pulsar Proxy.
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8613:
URL: https://github.com/apache/pulsar/pull/8613#issuecomment-731495671
/pulsarbot cherry-pick to branch-2.6
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8613: Support enable WebSocket on Pulsar Proxy.
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8613:
URL: https://github.com/apache/pulsar/pull/8613#issuecomment-731482843
/pulsarbot cherry-pick to branch-2.6
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a change in pull request #8613: Support enable WebSocket on Pulsar Proxy.
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #8613:
URL: https://github.com/apache/pulsar/pull/8613#discussion_r526712948
##########
File path: tests/integration/src/test/java/org/apache/pulsar/tests/integration/proxy/TestProxy.java
##########
@@ -53,6 +65,7 @@
proxyViaURL = new ProxyContainer(clusterName, "proxy-via-url")
.withEnv("brokerServiceURL", "pulsar://pulsar-broker-0:6650")
.withEnv("brokerWebServiceURL", "http://pulsar-broker-0:8080")
+ .withEnv("webSocketServiceEnabled", "true")
Review comment:
IIUC if we always enable websockets in this test we are losing to test the case in which websocket is disabled
is it correct ?
it would be better to have tests that cover default configurations together with tests that test additional features
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #8613: Support enable WebSocket on Pulsar Proxy.
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #8613:
URL: https://github.com/apache/pulsar/pull/8613#discussion_r527378832
##########
File path: tests/integration/src/test/java/org/apache/pulsar/tests/integration/proxy/TestProxy.java
##########
@@ -53,6 +65,7 @@
proxyViaURL = new ProxyContainer(clusterName, "proxy-via-url")
.withEnv("brokerServiceURL", "pulsar://pulsar-broker-0:6650")
.withEnv("brokerWebServiceURL", "http://pulsar-broker-0:8080")
+ .withEnv("webSocketServiceEnabled", "true")
Review comment:
Make sense, I have updated the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8613: Support enable WebSocket on Pulsar Proxy.
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8613:
URL: https://github.com/apache/pulsar/pull/8613#issuecomment-730370042
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8613: Support enable WebSocket on Pulsar Proxy.
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8613:
URL: https://github.com/apache/pulsar/pull/8613#issuecomment-730212549
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8613: Support enable WebSocket on Pulsar Proxy.
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8613:
URL: https://github.com/apache/pulsar/pull/8613#issuecomment-729700000
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #8613: Support enable WebSocket on Pulsar Proxy.
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #8613:
URL: https://github.com/apache/pulsar/pull/8613#issuecomment-730128412
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8613: Support enable WebSocket on Pulsar Proxy.
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8613:
URL: https://github.com/apache/pulsar/pull/8613#issuecomment-731481498
/pulsarbot cherry-pick to branch-2.6
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #8613: Support enable WebSocket on Pulsar Proxy.
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #8613:
URL: https://github.com/apache/pulsar/pull/8613#issuecomment-730524531
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #8613: Support enable WebSocket on Pulsar Proxy.
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #8613:
URL: https://github.com/apache/pulsar/pull/8613#issuecomment-730076499
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org