Re: [PR] [CALCITE-7440] Preserve correlated scope mapping in RelToSqlConverter [calcite]

["bvolpato (via GitHub)" <gi...@apache.org>]

bvolpato commented on PR #4828:
URL: https://github.com/apache/calcite/pull/4828#issuecomment-4378364138

   [review-prs-verification]
   Head: 614ce4ea1fafdda7fc590d30ef145b19af904440
   Ready to merge: yes
   
   Files reviewed:
   - core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java
   - core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java
   - core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterStructsTest.java
   - core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
   - piglet/src/test/java/org/apache/calcite/test/PigRelOpTest.java
   
   Tests/checks run and results:
   - Local: `./gradlew :core:test --tests org.apache.calcite.rel.rel2sql.RelToSqlConverterTest --tests org.apache.calcite.rel.rel2sql.RelToSqlConverterStructsTest :piglet:test --tests org.apache.calcite.test.PigRelOpTest :core:checkstyleMain :core:checkstyleTest :core:forbiddenApisMain :core:forbiddenApisTest :piglet:checkstyleTest :piglet:forbiddenApisTest :core:assemble :piglet:assemble` -> BUILD SUCCESSFUL
   - GitHub PR checks (`gh pr checks 4828 --watch`): all required checks passing (CI matrix + Jenkins + SonarCloud), with optional `Linux (JDK 8) Slow Tests` skipped.
   
   Fixes committed/pushed:
   - None. No completion blockers found in reviewed diff.
   
   Final CI status:
   - Passing on current head `614ce4ea1fafdda7fc590d30ef145b19af904440`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org