You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "AsfarHorani (via GitHub)" <gi...@apache.org> on 2023/06/12 17:28:31 UTC
[GitHub] [shardingsphere] AsfarHorani opened a new pull request, #26313: 26026-Inconsistent order of fields fixed in SQLParserRuleConfiguratio…
AsfarHorani opened a new pull request, #26313:
URL: https://github.com/apache/shardingsphere/pull/26313
…n.java
Fixes #26026
Changes proposed in this pull request:
- Removed the inconsistency from [SQLParserRuleConfiguration.java]
_____________________________________________________________________
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 26026-Inconsistent order of fields fixed in SQLParserRuleConfiguratio… [shardingsphere]
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang closed pull request #26313: 26026-Inconsistent order of fields fixed in SQLParserRuleConfiguratio…
URL: https://github.com/apache/shardingsphere/pull/26313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] AsfarHorani commented on pull request #26313: 26026-Inconsistent order of fields fixed in SQLParserRuleConfiguratio…
Posted by "AsfarHorani (via GitHub)" <gi...@apache.org>.
AsfarHorani commented on PR #26313:
URL: https://github.com/apache/shardingsphere/pull/26313#issuecomment-1591958705
@yx9o @RaigorJiang can u review this PR please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on pull request #26313: 26026-Inconsistent order of fields fixed in SQLParserRuleConfiguratio…
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on PR #26313:
URL: https://github.com/apache/shardingsphere/pull/26313#issuecomment-1592287588
Hi @AsfarHorani
Because the order of the fields is adjusted, the parameters for calling the constructor may need to be adjusted accordingly.
<img width="1057" alt="image" src="https://github.com/apache/shardingsphere/assets/5668787/cb464469-5e45-4383-b0e9-d4c7d2732fc2">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 26026-Inconsistent order of fields fixed in SQLParserRuleConfiguratio… [shardingsphere]
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on PR #26313:
URL: https://github.com/apache/shardingsphere/pull/26313#issuecomment-1993667916
Closed due to no response.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org