[jira] [Updated] (HADOOP-7430) Improve error message when moving to trash fails due to quota issue

["Ravi Prakash (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-7430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ravi Prakash updated HADOOP-7430:
---------------------------------

    Attachment: HADOOP-7430.1.patch

Attaching a patch to fix this regression. This patch applies to trunk revision 1141162.

Could someone please answer two of my questions?

1. In Trash.java I'm having to do a {noformat}cause.toString().indexOf("QuotaExceededException") != -1 {noformat} to find if the Exception was a QuotaExceededException (and then too it is not deterministic (what if the message contained that string?)). I would love to do an instanceOf but then HDFS would be added as a dependency to common (QuotaExceededException is defined in HDFS). How can I circumvent this / should I circumvent this? Can you please point me to a pre-existing discussion if one exists?
2. Similarly in TestTrash.java, to test that the message is also displayed when quota is exceeded, I should call setQuota() in hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java. Again, I'd have to add HDFS as a dependency for testing. I haven't done it in this patch.

Also, when I ran test-patch on this, I got
{noformat}
 [exec]     -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.
{noformat}
Here's test-patch's javadoc output
{noformat}
     [exec]   [javadoc] Constructing Javadoc information...
     [exec]   [javadoc] /home/raviprak/Code/hadoop/svn/svnhadoop-common/common/src/java/org/apache/hadoop/security/SecurityUtil.java:40: warning: sun.security.jgss.krb5.Krb5Util is Sun proprietary API and may be removed in a future release
     [exec]   [javadoc] import sun.security.jgss.krb5.Krb5Util;
     [exec]   [javadoc]                              ^
     [exec]   [javadoc] /home/raviprak/Code/hadoop/svn/svnhadoop-common/common/src/java/org/apache/hadoop/security/SecurityUtil.java:41: warning: sun.security.krb5.Credentials is Sun proprietary API and may be removed in a future release
     [exec]   [javadoc] import sun.security.krb5.Credentials;
     [exec]   [javadoc]                         ^
     [exec]   [javadoc] /home/raviprak/Code/hadoop/svn/svnhadoop-common/common/src/java/org/apache/hadoop/security/SecurityUtil.java:42: warning: sun.security.krb5.PrincipalName is Sun proprietary API and may be removed in a future release
     [exec]   [javadoc] import sun.security.krb5.PrincipalName;
     [exec]   [javadoc]                         ^
     [exec]   [javadoc] /home/raviprak/Code/hadoop/svn/svnhadoop-common/common/src/java/org/apache/hadoop/security/KerberosName.java:31: warning: sun.security.krb5.Config is Sun proprietary API and may be removed in a future release
     [exec]   [javadoc] import sun.security.krb5.Config;
     [exec]   [javadoc]                         ^
     [exec]   [javadoc] /home/raviprak/Code/hadoop/svn/svnhadoop-common/common/src/java/org/apache/hadoop/security/KerberosName.java:32: warning: sun.security.krb5.KrbException is Sun proprietary API and may be removed in a future release
     [exec]   [javadoc] import sun.security.krb5.KrbException;
     [exec]   [javadoc]                         ^
     [exec]   [javadoc] /home/raviprak/Code/hadoop/svn/svnhadoop-common/common/src/java/org/apache/hadoop/security/KerberosName.java:81: warning: sun.security.krb5.Config is Sun proprietary API and may be removed in a future release
     [exec]   [javadoc]   private static Config kerbConf;
     [exec]   [javadoc]                  ^
     [exec]   [javadoc] ExcludePrivateAnnotationsStandardDoclet
     [exec]   [javadoc] javadoc: warning - Error fetching URL: http://java.sun.com/javase/6/docs/api/package-list
     [exec]   [javadoc] Standard Doclet version 1.6.0_01
     [exec]   [javadoc] Building tree for all the packages and classes...
     [exec]   [javadoc] Building index for all the packages and classes...
     [exec]   [javadoc] Building index for all classes...
     [exec]   [javadoc] Generating /home/raviprak/Code/hadoop/svn/svnhadoop-common/common/build/docs/api/stylesheet.css...
     [exec]   [javadoc] 7 warnings
     [exec] 
     [exec] BUILD SUCCESSFUL
     [exec] Total time: 3 minutes 48 seconds
     [exec] 
     [exec] 
     [exec] There appear to be 7 javadoc warnings generated by the patched build.
{noformat}
But I didn't mess with any files. :( Any clues why I'm -1?

Thanks


> Improve error message when moving to trash fails due to quota issue
> -------------------------------------------------------------------
>
>                 Key: HADOOP-7430
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7430
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>            Reporter: Ravi Prakash
>            Assignee: Ravi Prakash
>            Priority: Minor
>         Attachments: HADOOP-7430.1.patch
>
>
> -rm command doesn't suggest -skipTrash on failure.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira