[GitHub] [spark] cloud-fan commented on a diff in pull request #36238: [SPARK-38916][CORE] Tasks not killed caused by race conditions between killTask() and launchTask()

[GitBox <gi...@apache.org>]

cloud-fan commented on code in PR #36238:
URL: https://github.com/apache/spark/pull/36238#discussion_r851872765


##########
core/src/main/scala/org/apache/spark/executor/Executor.scala:
##########
@@ -296,6 +332,9 @@ private[spark] class Executor(
       } else {
         taskRunner.kill(interruptThread = interruptThread, reason = reason)
       }
+    } else {
+      // Safe to remove kill mark as we got a chance with the TaskRunner.

Review Comment:
   this else branch means `taskRunner == null`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org