You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by GitBox <gi...@apache.org> on 2019/01/21 10:11:45 UTC
[GitHub] rhuss commented on a change in pull request #348: fix(kamel log):
Use integration name for looking up containers
rhuss commented on a change in pull request #348: fix(kamel log): Use integration name for looking up containers
URL: https://github.com/apache/camel-k/pull/348#discussion_r249389553
##########
File path: pkg/util/log/annotation_scraper.go
##########
@@ -36,16 +36,18 @@ import (
type SelectorScraper struct {
client kubernetes.Interface
namespace string
+ integrationName string
labelSelector string
podScrapers sync.Map
counter uint64
}
// NewSelectorScraper creates a new SelectorScraper
-func NewSelectorScraper(client kubernetes.Interface, namespace string, labelSelector string) *SelectorScraper {
+func NewSelectorScraper(client kubernetes.Interface, namespace string, integrationName string, labelSelector string) *SelectorScraper {
Review comment:
Ok, what's about `defaultContainerName` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services