You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/04/08 11:03:47 UTC

[GitHub] [cloudstack] shwstppr opened a new pull request, #6235: ui: use different icon labe for releaseIpAddress action

shwstppr opened a new pull request, #6235:
URL: https://github.com/apache/cloudstack/pull/6235

   ### Description
   
   In publicip view, actions `disassociateIpAddress` and `releaseIpAddress` actions are shown same which could cause confusion for user.
   Added a different icon and label for `releaseIpAddress` action
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   Before:
   ![Screenshot from 2022-04-08 15-27-19](https://user-images.githubusercontent.com/153340/162423457-dc974a42-0b50-4741-82ab-fe99e8849974.png)
   
   
   After:
   ![Screenshot from 2022-04-08 16-32-14](https://user-images.githubusercontent.com/153340/162423393-c903d4a9-402d-4f5c-90b0-8bebacf5193e.png)
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6235: ui: use different icon labe for releaseIpAddress action

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6235:
URL: https://github.com/apache/cloudstack/pull/6235#issuecomment-1092764930

   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6235 (SL-JID-1353)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez merged pull request #6235: ui: use different icon label for releaseIpAddress action

Posted by GitBox <gi...@apache.org>.
nvazquez merged PR #6235:
URL: https://github.com/apache/cloudstack/pull/6235


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6235: ui: use different icon labe for releaseIpAddress action

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6235:
URL: https://github.com/apache/cloudstack/pull/6235#issuecomment-1092761148

   @Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Pearl1594 commented on pull request #6235: ui: use different icon labe for releaseIpAddress action

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on PR #6235:
URL: https://github.com/apache/cloudstack/pull/6235#issuecomment-1092760600

   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org