You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/04/04 12:03:35 UTC
[GitHub] [ozone] rakeshadr commented on a diff in pull request #3265: HDDS-6523. Refine OMClientRequest Classes to handle bucket layout better.
rakeshadr commented on code in PR #3265:
URL: https://github.com/apache/ozone/pull/3265#discussion_r841660411
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/OMKeyRequestFactory.java:
##########
@@ -66,43 +55,56 @@ public static OMKeyRequest createRequest(OMRequest omRequest,
switch (cmdType) {
case CreateDirectory:
keyArgs = omRequest.getCreateDirectoryRequest().getKeyArgs();
- omKeyRequest = OMDirectoryCreateRequest
- .getInstance(keyArgs, omRequest, ozoneManager);
+ omKeyRequest = BucketLayoutAwareOMKeyRequestFactory.createRequest(
+ keyArgs.getVolumeName(), keyArgs.getBucketName(), omRequest,
+ ozoneManager);
break;
case CreateFile:
keyArgs = omRequest.getCreateFileRequest().getKeyArgs();
- omKeyRequest =
- OMFileCreateRequest.getInstance(keyArgs, omRequest, ozoneManager);
+ omKeyRequest = BucketLayoutAwareOMKeyRequestFactory.createRequest(
+ keyArgs.getVolumeName(), keyArgs.getBucketName(), omRequest,
+ ozoneManager);
break;
case CreateKey:
keyArgs = omRequest.getCreateKeyRequest().getKeyArgs();
- omKeyRequest =
- OMKeyCreateRequest.getInstance(keyArgs, omRequest, ozoneManager);
+ omKeyRequest = BucketLayoutAwareOMKeyRequestFactory.createRequest(
+ keyArgs.getVolumeName(), keyArgs.getBucketName(), omRequest,
+ ozoneManager);
break;
case AllocateBlock:
keyArgs = omRequest.getAllocateBlockRequest().getKeyArgs();
- omKeyRequest = OMAllocateBlockRequest
- .getInstance(keyArgs, omRequest, ozoneManager);
+ omKeyRequest = BucketLayoutAwareOMKeyRequestFactory.createRequest(
+ keyArgs.getVolumeName(), keyArgs.getBucketName(), omRequest,
+ ozoneManager);
break;
case CommitKey:
keyArgs = omRequest.getCommitKeyRequest().getKeyArgs();
- omKeyRequest =
- OMKeyCommitRequest.getInstance(keyArgs, omRequest, ozoneManager);
+ omKeyRequest = BucketLayoutAwareOMKeyRequestFactory.createRequest(
+ keyArgs.getVolumeName(), keyArgs.getBucketName(), omRequest,
+ ozoneManager);
break;
case DeleteKey:
keyArgs = omRequest.getDeleteKeyRequest().getKeyArgs();
- omKeyRequest =
- OMKeyDeleteRequest.getInstance(keyArgs, omRequest, ozoneManager);
+ omKeyRequest = BucketLayoutAwareOMKeyRequestFactory.createRequest(
+ keyArgs.getVolumeName(), keyArgs.getBucketName(), omRequest,
+ ozoneManager);
break;
case DeleteKeys:
return new OMKeysDeleteRequest(omRequest);
Review Comment:
@JyotinderSingh Please add this also to the factory class.
```
case DeleteKeys:
OzoneManagerProtocolProtos.DeleteKeyArgs deleteKeyArgs =
omRequest.getDeleteKeysRequest().getDeleteKeys();
omKeyRequest = BucketLayoutAwareOMKeyRequestFactory.createRequest(
deleteKeyArgs.getVolumeName(), deleteKeyArgs.getBucketName(), omRequest,
ozoneManager);
break;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org