You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by Lin Guo <gu...@yahoo.com> on 2010/12/09 10:33:24 UTC

Review Request: Add load/store function AvroStorage for avro data

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/155/
-----------------------------------------------------------

Review request for pig.


Summary
-------

Detailed documentation can be found in http://snaprojects.jira.com/wiki/display/HTOOLS/AvroStorage+-+Pig+support+for+Avro+data


This addresses bug PIG-1748.
    https://issues.apache.org/jira/browse/PIG-1748


Diffs
-----

  trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/ASCommons.java PRE-CREATION 
  trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/ASFsInput.java PRE-CREATION 
  trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/ASLog.java PRE-CREATION 
  trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroSchema2Pig.java PRE-CREATION 
  trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroSchemaManager.java PRE-CREATION 
  trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorage.java PRE-CREATION 
  trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroDatumReader.java PRE-CREATION 
  trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroDatumWriter.java PRE-CREATION 
  trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroInputFormat.java PRE-CREATION 
  trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroOutputFormat.java PRE-CREATION 
  trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java PRE-CREATION 
  trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordWriter.java PRE-CREATION 
  trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigSchema2Avro.java PRE-CREATION 
  trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/TestAvroStorage.java PRE-CREATION 
  trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/TestAvroStorageData/expected_testArrayDefault.avro UNKNOWN 
  trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/TestAvroStorageData/expected_testArrayWithSchema.avro UNKNOWN 
  trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/TestAvroStorageData/expected_testRecordSplit1.avro UNKNOWN 
  trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/TestAvroStorageData/expected_testRecordSplit2.avro UNKNOWN 
  trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/TestAvroStorageData/expected_testRecordWithFieldSchema.avro UNKNOWN 
  trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/TestAvroStorageData/test_array.avro UNKNOWN 
  trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/TestAvroStorageData/test_record.avro UNKNOWN 
  trunk/ivy.xml 1040872 
  trunk/ivy/libraries.properties 1043236 

Diff: https://reviews.apache.org/r/155/diff


Testing
-------

    [exec] +1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 19 new or modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
     [exec] 
     [exec] 


Thanks,

Lin