You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apex.apache.org by PramodSSImmaneni <gi...@git.apache.org> on 2015/09/25 10:50:33 UTC
[GitHub] incubator-apex-core pull request: App not launching with HA and se...
GitHub user PramodSSImmaneni opened a pull request:
https://github.com/apache/incubator-apex-core/pull/83
App not launching with HA and security enabled under CDH 5.4.4 (APEX-116)
This was because of a different config property where rm address was specified than what we were looking for. The fix includes using the new property yarn.resourcemanager.address configuration with higher priority then using the previous yarn.resourcemanager.hostname property to get rm address in HA mode.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PramodSSImmaneni/incubator-apex-core apex-116
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-core/pull/83.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #83
----
commit 7960d13a09f59bccd88ff284cfccf334eb044d6b
Author: Pramod Immaneni <pr...@datatorrent.com>
Date: 2015-09-25T08:39:48Z
Using yarn.resourcemanager.address configuration first to get rm address in HA mode and if that is not found then using yarn.resourcemanager.hostname configuration
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: App not launching with HA and se...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-core/pull/83
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: App not launching with HA and se...
Posted by PramodSSImmaneni <gi...@git.apache.org>.
Github user PramodSSImmaneni commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/83#discussion_r40901158
--- Diff: engine/src/main/java/com/datatorrent/stram/client/StramClientUtils.java ---
@@ -284,6 +279,20 @@ public void addRMDelegationToken(final String renewer, final Credentials credent
credentials.addToken(token.getService(), token);
}
+ public InetSocketAddress getRMHAAddress(String rmId)
+ {
+ YarnConfiguration yarnConf;
+ if (conf instanceof YarnConfiguration) {
+ yarnConf = (YarnConfiguration)conf;
+ } else {
+ yarnConf = new YarnConfiguration(conf);
+ }
+ yarnConf.set(ConfigUtils.RM_HA_ID, rmId);
+ InetSocketAddress socketAddr = yarnConf.getSocketAddr(YarnConfiguration.RM_ADDRESS, YarnConfiguration.DEFAULT_NM_ADDRESS, YarnConfiguration.DEFAULT_RM_PORT);
--- End diff --
Fixed it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: App not launching with HA and se...
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/83#issuecomment-145316778
tested on hdpsec-ha cluster.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: App not launching with HA and se...
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/83#discussion_r40880696
--- Diff: engine/src/main/java/com/datatorrent/stram/client/StramClientUtils.java ---
@@ -284,6 +279,20 @@ public void addRMDelegationToken(final String renewer, final Credentials credent
credentials.addToken(token.getService(), token);
}
+ public InetSocketAddress getRMHAAddress(String rmId)
+ {
+ YarnConfiguration yarnConf;
+ if (conf instanceof YarnConfiguration) {
+ yarnConf = (YarnConfiguration)conf;
+ } else {
+ yarnConf = new YarnConfiguration(conf);
+ }
+ yarnConf.set(ConfigUtils.RM_HA_ID, rmId);
+ InetSocketAddress socketAddr = yarnConf.getSocketAddr(YarnConfiguration.RM_ADDRESS, YarnConfiguration.DEFAULT_NM_ADDRESS, YarnConfiguration.DEFAULT_RM_PORT);
--- End diff --
It looks like a typo here. Should it be YarnConfiguration.DEFAULT_RM_ADDRESS, and not YarnConfiguration.DEFAULT_NM_ADDRESS.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: App not launching with HA and se...
Posted by PramodSSImmaneni <gi...@git.apache.org>.
Github user PramodSSImmaneni commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/83#issuecomment-144897743
Will squash it. I didn't try by setting the connect address property. If you have a setup handy it would be great if you could give it a try. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: App not launching with HA and se...
Posted by PramodSSImmaneni <gi...@git.apache.org>.
Github user PramodSSImmaneni commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/83#issuecomment-144621482
Vlad can you review this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: App not launching with HA and se...
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/83#issuecomment-144895491
Looks good, can you squash commits. Do you want me to test the fix on the HA Secure cluster or this was already done?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: App not launching with HA and se...
Posted by PramodSSImmaneni <gi...@git.apache.org>.
Github user PramodSSImmaneni commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/83#issuecomment-145366578
Thanks. Squashed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---