You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/04/09 23:06:12 UTC
Review Request 20179: Added test for slave stopping before containerizer
launches.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20179/
-----------------------------------------------------------
Review request for mesos, Niklas Nielsen and Vinod Kone.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/tests/containerizer.hpp a9f15318803aeb41489a48d7e9e94caa97d71456
src/tests/containerizer.cpp bfb93412b801a24ac77bf621d55ebb00bfd4fdd7
src/tests/slave_recovery_tests.cpp 72b6d42f0895f10fed041a5a1351e79b003e2d1b
Diff: https://reviews.apache.org/r/20179/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 20179: Added test for slave stopping before containerizer
launches.
Posted by Niklas Nielsen <ni...@qni.dk>.
> On April 10, 2014, 7:26 a.m., Niklas Nielsen wrote:
> > Awesome test! Works great to exercise the new task info recovery code.
Ping :) the test looks great - let's get this committed.
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20179/#review40007
-----------------------------------------------------------
On April 9, 2014, 2:06 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20179/
> -----------------------------------------------------------
>
> (Updated April 9, 2014, 2:06 p.m.)
>
>
> Review request for mesos, Niklas Nielsen and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/containerizer.hpp a9f15318803aeb41489a48d7e9e94caa97d71456
> src/tests/containerizer.cpp bfb93412b801a24ac77bf621d55ebb00bfd4fdd7
> src/tests/slave_recovery_tests.cpp 72b6d42f0895f10fed041a5a1351e79b003e2d1b
>
> Diff: https://reviews.apache.org/r/20179/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 20179: Added test for slave stopping before containerizer
launches.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20179/#review40007
-----------------------------------------------------------
Ship it!
Awesome test! Works great to exercise the new task info recovery code.
src/tests/containerizer.cpp
<https://reviews.apache.org/r/20179/#comment72792>
Can we do the same change here (from CHECK to Failure/LOG(WARNING)+return)? If not, I will just do it in a subsequent RR :)
The new recover code in the task-info patch will call destroy on the container (which is unknown as launch is discarded up front).
- Niklas Nielsen
On April 9, 2014, 2:06 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20179/
> -----------------------------------------------------------
>
> (Updated April 9, 2014, 2:06 p.m.)
>
>
> Review request for mesos, Niklas Nielsen and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/containerizer.hpp a9f15318803aeb41489a48d7e9e94caa97d71456
> src/tests/containerizer.cpp bfb93412b801a24ac77bf621d55ebb00bfd4fdd7
> src/tests/slave_recovery_tests.cpp 72b6d42f0895f10fed041a5a1351e79b003e2d1b
>
> Diff: https://reviews.apache.org/r/20179/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 20179: Added test for slave stopping before containerizer
launches.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20179/#review40671
-----------------------------------------------------------
Ship it!
src/tests/containerizer.cpp
<https://reviews.apache.org/r/20179/#comment73728>
s/former/latter/?
- Vinod Kone
On April 9, 2014, 9:06 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20179/
> -----------------------------------------------------------
>
> (Updated April 9, 2014, 9:06 p.m.)
>
>
> Review request for mesos, Niklas Nielsen and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/containerizer.hpp a9f15318803aeb41489a48d7e9e94caa97d71456
> src/tests/containerizer.cpp bfb93412b801a24ac77bf621d55ebb00bfd4fdd7
> src/tests/slave_recovery_tests.cpp 72b6d42f0895f10fed041a5a1351e79b003e2d1b
>
> Diff: https://reviews.apache.org/r/20179/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 20179: Added test for slave stopping before containerizer
launches.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20179/#review39936
-----------------------------------------------------------
Patch looks great!
Reviews applied: [20179]
All tests passed.
- Mesos ReviewBot
On April 9, 2014, 9:06 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20179/
> -----------------------------------------------------------
>
> (Updated April 9, 2014, 9:06 p.m.)
>
>
> Review request for mesos, Niklas Nielsen and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/containerizer.hpp a9f15318803aeb41489a48d7e9e94caa97d71456
> src/tests/containerizer.cpp bfb93412b801a24ac77bf621d55ebb00bfd4fdd7
> src/tests/slave_recovery_tests.cpp 72b6d42f0895f10fed041a5a1351e79b003e2d1b
>
> Diff: https://reviews.apache.org/r/20179/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>