[GitHub] [calcite] chunweilei commented on a change in pull request #1167: [CALCITE-3009] It should fail if there are duplicate keys in a .xml file

[GitBox <gi...@apache.org>]

chunweilei commented on a change in pull request #1167: [CALCITE-3009] It should fail if there are duplicate keys in a .xml file
URL: https://github.com/apache/calcite/pull/1167#discussion_r276103161
 
 

 ##########
 File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml
 ##########
 @@ -9328,35 +9328,6 @@ LogicalProject(NAME=[$0], ENAME=[$2])
       Uncollect
         LogicalProject(EMPLOYEES=[$cor1.EMPLOYEES])
           LogicalValues(tuples=[[{ 0 }]])
-]]>
-        </Resource>
-    </TestCase>
-    <TestCase name="testProjectCorrelateTranspose">
-        <Resource name="sql">
-            <![CDATA[select t1.name, t2.ename
-from DEPT_NESTED as t1,
-unnest(t1.employees) as t2]]>
 
 Review comment:
   Note that `testProjectCorrelateTranspose` is redundant[1][2].
   
   [1] https://github.com/apache/calcite/blob/master/core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml#L9226
   [2] https://github.com/apache/calcite/blob/master/core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml#L9253

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services