You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Stein Welberg <ma...@steinwelberg.nl> on 2011/11/23 22:05:29 UTC
Review Request: Implement getName in FieldRestrictingPerson to return Name
object in OpenSocial calls
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2924/
-----------------------------------------------------------
Review request for rave and Jasha Joachimsthal.
Summary
-------
Add the name (name: {formatted: '', givenName: '', familyName: ''...) object to the response when requesting person information using the opensocial interface in rave-shindig
Diffs
-----
/trunk/rave-shindig/src/main/java/org/apache/rave/opensocial/service/impl/FieldRestrictingPerson.java 1205382
Diff: https://reviews.apache.org/r/2924/diff
Testing
-------
Thanks,
Stein
Re: Review Request: Implement getName in FieldRestrictingPerson to return
Name object in OpenSocial calls
Posted by mf...@apache.org.
> On 2011-11-24 09:54:14, Jasha Joachimsthal wrote:
> > Thanks for the patch!
Did you attach this to a JIRA issue? With patches we want to make sure that we make a clean transfer of IP. If you can create a JIRA issue at https://issues.apache.org/jira/browse/RAVE and attach the patch file, I will apply it today.
- mfranklin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2924/#review3500
-----------------------------------------------------------
On 2011-11-23 21:05:29, Stein Welberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2924/
> -----------------------------------------------------------
>
> (Updated 2011-11-23 21:05:29)
>
>
> Review request for rave and Jasha Joachimsthal.
>
>
> Summary
> -------
>
> Add the name (name: {formatted: '', givenName: '', familyName: ''...) object to the response when requesting person information using the opensocial interface in rave-shindig
>
>
> Diffs
> -----
>
> /trunk/rave-shindig/src/main/java/org/apache/rave/opensocial/service/impl/FieldRestrictingPerson.java 1205382
>
> Diff: https://reviews.apache.org/r/2924/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Stein
>
>
Re: Review Request: Implement getName in FieldRestrictingPerson to return
Name object in OpenSocial calls
Posted by Jasha Joachimsthal <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2924/#review3500
-----------------------------------------------------------
Ship it!
Thanks for the patch!
- Jasha
On 2011-11-23 21:05:29, Stein Welberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2924/
> -----------------------------------------------------------
>
> (Updated 2011-11-23 21:05:29)
>
>
> Review request for rave and Jasha Joachimsthal.
>
>
> Summary
> -------
>
> Add the name (name: {formatted: '', givenName: '', familyName: ''...) object to the response when requesting person information using the opensocial interface in rave-shindig
>
>
> Diffs
> -----
>
> /trunk/rave-shindig/src/main/java/org/apache/rave/opensocial/service/impl/FieldRestrictingPerson.java 1205382
>
> Diff: https://reviews.apache.org/r/2924/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Stein
>
>
Re: Review Request: Implement getName in FieldRestrictingPerson to return
Name object in OpenSocial calls
Posted by mf...@apache.org.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2924/#review3491
-----------------------------------------------------------
Ship it!
I still have an open task to finish Implementing the FRP, but haven't done name yet. This is exactly what I was going to do for it. I can apply his...
- mfranklin
On 2011-11-23 21:05:29, Stein Welberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2924/
> -----------------------------------------------------------
>
> (Updated 2011-11-23 21:05:29)
>
>
> Review request for rave and Jasha Joachimsthal.
>
>
> Summary
> -------
>
> Add the name (name: {formatted: '', givenName: '', familyName: ''...) object to the response when requesting person information using the opensocial interface in rave-shindig
>
>
> Diffs
> -----
>
> /trunk/rave-shindig/src/main/java/org/apache/rave/opensocial/service/impl/FieldRestrictingPerson.java 1205382
>
> Diff: https://reviews.apache.org/r/2924/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Stein
>
>