You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/09/28 21:46:37 UTC

Review Request 38819: Fixed a bug in cgroups test filter.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38819/
-----------------------------------------------------------

Review request for mesos, Ben Mahler and Paul Brett.


Repository: mesos


Description
-------

Fixed a bug in cgroups test filter.

Otherwise, CgroupsNoHierarchyTest.ROOT_CGROUPS_NOHIERARCHY_MountUnmountHierarchy will run even if there are hierarchies being mounted.


Diffs
-----

  src/tests/environment.cpp 000b2010831039f961c0ee9bb83cb1929da66197 

Diff: https://reviews.apache.org/r/38819/diff/


Testing
-------

sudo make check


Thanks,

Jie Yu

Re: Review Request 38819: Fixed a bug in cgroups test filter.

Posted by Ben Mahler <be...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38819/#review100853
-----------------------------------------------------------

Ship it!


Much appreciated :)

- Ben Mahler


On Sept. 28, 2015, 7:46 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38819/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2015, 7:46 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Paul Brett.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed a bug in cgroups test filter.
> 
> Otherwise, CgroupsNoHierarchyTest.ROOT_CGROUPS_NOHIERARCHY_MountUnmountHierarchy will run even if there are hierarchies being mounted.
> 
> 
> Diffs
> -----
> 
>   src/tests/environment.cpp 000b2010831039f961c0ee9bb83cb1929da66197 
> 
> Diff: https://reviews.apache.org/r/38819/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>