You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/06/20 13:44:16 UTC
[GitHub] flink pull request #4148: [FLINK-6956] Make table example POJO classes publi...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4148
[FLINK-6956] Make table example POJO classes public
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 6956
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4148.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4148
----
commit 5a97dcd245dcf62a8001a9b9c5d351557c9b64fa
Author: zentol <ch...@apache.org>
Date: 2017-06-20T13:42:13Z
[FLINK-6956] Make table example POJO classes public
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4148: [FLINK-6956] Make table example POJO classes public
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4148
Did we overlook adding a test to run the table examples? I think we do this for streaming and batch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4148: [FLINK-6956] Make table example POJO classes publi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4148
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4148: [FLINK-6956] Make table example POJO classes public
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/4148
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4148: [FLINK-6956] Make table example POJO classes public
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4148
Will fix the typo while merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4148: [FLINK-6956] Make table example POJO classes public
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/4148
Yes, there are no tests, but the examples need to be reworked soon anyway. The Table API has much more features than shown in this very simple examples.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4148: [FLINK-6956] Make table example POJO classes publi...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4148#discussion_r123014213
--- Diff: flink-examples/flink-examples-table/src/main/java/org/apache/flink/table/examples/java/WordCountSQL.java ---
@@ -65,7 +65,10 @@ public static void main(String[] args) throws Exception {
// USER DATA TYPES
// *************************************************************************
- private static class WC {
+ /**
+ * Simple POJO containing a word and it's respective count.
--- End diff --
"its" (and below)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---