You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/09 08:51:47 UTC
[GitHub] [pulsar] zymap opened a new pull request #8019: Fix the null exception when starting the proxy service
zymap opened a new pull request #8019:
URL: https://github.com/apache/pulsar/pull/8019
---
Fixes #7960
*Motivation*
When enable the broker tls and enable broker client authentication with oauth2 plugin,
the proxy service will exit with an unexpected null exception.
Because there are some methods call the authentication before initializing the flow
which will cause the token client isn't initialized before using.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] EronWright commented on pull request #8019: Fix the null exception when starting the proxy service
Posted by GitBox <gi...@apache.org>.
EronWright commented on pull request #8019:
URL: https://github.com/apache/pulsar/pull/8019#issuecomment-930584223
@zymap I just noticed this fix, and do you recall why you fixed it in this way. The true issue looks to me that the `Authentication` interface has a `start` method and a `getAuthData` method but that the `PulsarProxy` calls `getAuthData` before calling `start`. The OAuth2 implementation assumes that `start` will be called first. This PR avoids taking that assumption, but is it not a correct assumption to make?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on a change in pull request #8019: Fix the null exception when starting the proxy service
Posted by GitBox <gi...@apache.org>.
zymap commented on a change in pull request #8019:
URL: https://github.com/apache/pulsar/pull/8019#discussion_r485627921
##########
File path: pulsar-proxy/pom.xml
##########
@@ -171,5 +171,12 @@
<groupId>com.beust</groupId>
<artifactId>jcommander</artifactId>
</dependency>
+
+ <dependency>
+ <groupId>${project.groupId}</groupId>
+ <artifactId>bouncy-castle-bcfips</artifactId>
Review comment:
Sure. Updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #8019: Fix the null exception when starting the proxy service
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8019:
URL: https://github.com/apache/pulsar/pull/8019#issuecomment-690851584
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #8019: Fix the null exception when starting the proxy service
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8019:
URL: https://github.com/apache/pulsar/pull/8019#issuecomment-690851584
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #8019: Fix the null exception when starting the proxy service
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8019:
URL: https://github.com/apache/pulsar/pull/8019#issuecomment-690797773
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] EronWright commented on pull request #8019: Fix the null exception when starting the proxy service
Posted by GitBox <gi...@apache.org>.
EronWright commented on pull request #8019:
URL: https://github.com/apache/pulsar/pull/8019#issuecomment-930584223
@zymap I just noticed this fix, and do you recall why you fixed it in this way. The true issue looks to me that the `Authentication` interface has a `start` method and a `getAuthData` method but that the `PulsarProxy` calls `getAuthData` before calling `start`. The OAuth2 implementation assumes that `start` will be called first. This PR avoids taking that assumption, but is it not a correct assumption to make?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #8019: Fix the null exception when starting the proxy service
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #8019:
URL: https://github.com/apache/pulsar/pull/8019
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #8019: Fix the null exception when starting the proxy service
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #8019:
URL: https://github.com/apache/pulsar/pull/8019
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #8019: Fix the null exception when starting the proxy service
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8019:
URL: https://github.com/apache/pulsar/pull/8019#issuecomment-690851584
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #8019: Fix the null exception when starting the proxy service
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8019:
URL: https://github.com/apache/pulsar/pull/8019#issuecomment-689955091
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #8019: Fix the null exception when starting the proxy service
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8019:
URL: https://github.com/apache/pulsar/pull/8019#issuecomment-689903273
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on a change in pull request #8019: Fix the null exception when starting the proxy service
Posted by GitBox <gi...@apache.org>.
jiazhai commented on a change in pull request #8019:
URL: https://github.com/apache/pulsar/pull/8019#discussion_r485505239
##########
File path: pulsar-proxy/pom.xml
##########
@@ -171,5 +171,12 @@
<groupId>com.beust</groupId>
<artifactId>jcommander</artifactId>
</dependency>
+
+ <dependency>
+ <groupId>${project.groupId}</groupId>
+ <artifactId>bouncy-castle-bcfips</artifactId>
Review comment:
@zymap Could this be changed into `bouncy-castle-bc` instead of bouncy-castle-bcfips? bc is used more widly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #8019: Fix the null exception when starting the proxy service
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #8019:
URL: https://github.com/apache/pulsar/pull/8019
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org