You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dinesh Bhat (Code Review)" <ge...@cloudera.org> on 2016/12/08 08:05:06 UTC
[kudu-CR] KUDU-1796: Use last REPLICATE OpId instead of last COMMIT OpId to tombstone a tablet replica
Hello Mike Percy, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5416
to review the following change.
Change subject: KUDU-1796: Use last REPLICATE OpId instead of last COMMIT OpId to tombstone a tablet replica
......................................................................
KUDU-1796: Use last REPLICATE OpId instead of last COMMIT OpId to tombstone a tablet replica
The kudu-tool-test has been flaky because of the following failure:
kudu-tool-test.cc:1203: Failure
Value of: tombstoned_opid.index()
Actual: 205
Expected: last_logged_opid.index()
Which is: 206
Issue here is, offline cli tool "local_replica delete" stored
last COMMIT OpId on the tablet superblock instead of last REPLICATE
OpId while tombstoning the tablet replica. Hence kudu-tool-test
ToolTest.TestLocalReplicaTombstoneDelete observed that sometimes
tombstoned_opid (COMMIT) lagged behind last_logged_opid (REPLICATE).
This patch fixes the tool to use the REPLICATE OpId from the WAL.
Testing: Ran 5000 iterations of current failing test.
Change-Id: I02e95f05fab80e94b1afd078b23e5e03eca6e42a
---
M src/kudu/tools/tool_action_local_replica.cc
1 file changed, 15 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/5416/1
--
To view, visit http://gerrit.cloudera.org:8080/5416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I02e95f05fab80e94b1afd078b23e5e03eca6e42a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-1796: Use last REPLICATE OpId instead of last COMMIT OpId to tombstone a tablet replica
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.
Change subject: KUDU-1796: Use last REPLICATE OpId instead of last COMMIT OpId to tombstone a tablet replica
......................................................................
KUDU-1796: Use last REPLICATE OpId instead of last COMMIT OpId to tombstone a tablet replica
The kudu-tool-test has been flaky because of the following failure:
kudu-tool-test.cc:1203: Failure
Value of: tombstoned_opid.index()
Actual: 205
Expected: last_logged_opid.index()
Which is: 206
Issue here is, offline cli tool "local_replica delete" stored
last COMMIT OpId on the tablet superblock instead of last REPLICATE
OpId while tombstoning the tablet replica. Hence kudu-tool-test
ToolTest.TestLocalReplicaTombstoneDelete observed that sometimes
tombstoned_opid (COMMIT) lagged behind last_logged_opid (REPLICATE).
This patch fixes the tool to use the REPLICATE OpId from the WAL.
Testing: Ran 5000 iterations of current failing test.
Change-Id: I02e95f05fab80e94b1afd078b23e5e03eca6e42a
Reviewed-on: http://gerrit.cloudera.org:8080/5416
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/tools/tool_action_local_replica.cc
1 file changed, 15 insertions(+), 15 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I02e95f05fab80e94b1afd078b23e5e03eca6e42a
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-1796: Use last REPLICATE OpId instead of last COMMIT OpId to tombstone a tablet replica
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: KUDU-1796: Use last REPLICATE OpId instead of last COMMIT OpId to tombstone a tablet replica
......................................................................
Patch Set 1:
(1 comment)
Whoops. Good catch. Looks good, just an error message nit.
http://gerrit.cloudera.org:8080/#/c/5416/1/src/kudu/tools/tool_action_local_replica.cc
File src/kudu/tools/tool_action_local_replica.cc:
PS1, Line 192: "No Replicated OpIds found in the log"
How about: "No entries found in the write-ahead log"
--
To view, visit http://gerrit.cloudera.org:8080/5416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02e95f05fab80e94b1afd078b23e5e03eca6e42a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1796: Use last REPLICATE OpId instead of last COMMIT OpId to tombstone a tablet replica
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: KUDU-1796: Use last REPLICATE OpId instead of last COMMIT OpId to tombstone a tablet replica
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02e95f05fab80e94b1afd078b23e5e03eca6e42a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-1796: Use last REPLICATE OpId instead of last COMMIT OpId to tombstone a tablet replica
Posted by "Dinesh Bhat (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5416
to look at the new patch set (#2).
Change subject: KUDU-1796: Use last REPLICATE OpId instead of last COMMIT OpId to tombstone a tablet replica
......................................................................
KUDU-1796: Use last REPLICATE OpId instead of last COMMIT OpId to tombstone a tablet replica
The kudu-tool-test has been flaky because of the following failure:
kudu-tool-test.cc:1203: Failure
Value of: tombstoned_opid.index()
Actual: 205
Expected: last_logged_opid.index()
Which is: 206
Issue here is, offline cli tool "local_replica delete" stored
last COMMIT OpId on the tablet superblock instead of last REPLICATE
OpId while tombstoning the tablet replica. Hence kudu-tool-test
ToolTest.TestLocalReplicaTombstoneDelete observed that sometimes
tombstoned_opid (COMMIT) lagged behind last_logged_opid (REPLICATE).
This patch fixes the tool to use the REPLICATE OpId from the WAL.
Testing: Ran 5000 iterations of current failing test.
Change-Id: I02e95f05fab80e94b1afd078b23e5e03eca6e42a
---
M src/kudu/tools/tool_action_local_replica.cc
1 file changed, 15 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/5416/2
--
To view, visit http://gerrit.cloudera.org:8080/5416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I02e95f05fab80e94b1afd078b23e5e03eca6e42a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-1796: Use last REPLICATE OpId instead of last COMMIT OpId to tombstone a tablet replica
Posted by "Dinesh Bhat (Code Review)" <ge...@cloudera.org>.
Dinesh Bhat has posted comments on this change.
Change subject: KUDU-1796: Use last REPLICATE OpId instead of last COMMIT OpId to tombstone a tablet replica
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5416/1/src/kudu/tools/tool_action_local_replica.cc
File src/kudu/tools/tool_action_local_replica.cc:
PS1, Line 192: "No entries found in the write-ahead l
> How about: "No entries found in the write-ahead log"
Done
--
To view, visit http://gerrit.cloudera.org:8080/5416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02e95f05fab80e94b1afd078b23e5e03eca6e42a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes