You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/12/03 06:51:46 UTC
[GitHub] [shardingsphere-elasticjob] kdYY opened a new pull request #1756: snapshotService log the actual port
kdYY opened a new pull request #1756:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1756
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
-
-
-
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on a change in pull request #1756: snapshotService log the actual port
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on a change in pull request #1756:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1756#discussion_r534761823
##########
File path: elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/snapshot/SnapshotService.java
##########
@@ -62,14 +62,13 @@ public SnapshotService(final CoordinatorRegistryCenter regCenter, final int port
*/
public void listen() {
try {
- log.info("ElasticJob: Snapshot service is running on port '{}'", port);
- openSocket(port);
+ log.info("ElasticJob: Snapshot service is running on port '{}'", openSocket(port));
} catch (final IOException ex) {
log.error("ElasticJob: Snapshot service listen failure, error is: ", ex);
}
}
- private void openSocket(final int port) throws IOException {
+ private int openSocket(final int port) throws IOException {
serverSocket = new ServerSocket(port);
String threadName = String.format("elasticjob-snapshot-service-%d", port);
Review comment:
Thread name should use actual port.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN merged pull request #1756: snapshotService log the actual port
Posted by GitBox <gi...@apache.org>.
TeslaCN merged pull request #1756:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1756
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-io commented on pull request #1756: snapshotService log the actual port
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1756:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1756#issuecomment-737709060
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1756?src=pr&el=h1) Report
> Merging [#1756](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1756?src=pr&el=desc) (f206a07) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/5588258155612ecafb6b30381bbca0d34949f243?el=desc) (5588258) will **decrease** coverage by `0.05%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1756?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1756 +/- ##
============================================
- Coverage 86.02% 85.97% -0.06%
Complexity 108 108
============================================
Files 255 255
Lines 5740 5739 -1
Branches 885 885
============================================
- Hits 4938 4934 -4
- Misses 483 484 +1
- Partials 319 321 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1756?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1756/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `80.64% <100.00%> (-0.31%)` | `0.00 <0.00> (ø)` | |
| [...e/shardingsphere/elasticjob/infra/env/IpUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1756/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9lbnYvSXBVdGlscy5qYXZh) | `60.00% <0.00%> (-4.62%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1756?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1756?src=pr&el=footer). Last update [5588258...9f9bc70](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1756?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-io edited a comment on pull request #1756: snapshotService log the actual port
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1756:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1756#issuecomment-737709060
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1756?src=pr&el=h1) Report
> Merging [#1756](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1756?src=pr&el=desc) (9f9bc70) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/5588258155612ecafb6b30381bbca0d34949f243?el=desc) (5588258) will **decrease** coverage by `0.05%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1756?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1756 +/- ##
============================================
- Coverage 86.02% 85.97% -0.06%
Complexity 108 108
============================================
Files 255 255
Lines 5740 5740
Branches 885 885
============================================
- Hits 4938 4935 -3
- Misses 483 484 +1
- Partials 319 321 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1756?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1756/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `80.95% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...e/shardingsphere/elasticjob/infra/env/IpUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1756/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9lbnYvSXBVdGlscy5qYXZh) | `60.00% <0.00%> (-4.62%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1756?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1756?src=pr&el=footer). Last update [5588258...9f9bc70](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1756?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-io edited a comment on pull request #1756: snapshotService log the actual port
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1756:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1756#issuecomment-737709060
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1756?src=pr&el=h1) Report
> Merging [#1756](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1756?src=pr&el=desc) (f206a07) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/5588258155612ecafb6b30381bbca0d34949f243?el=desc) (5588258) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1756?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1756 +/- ##
============================================
- Coverage 86.02% 86.02% -0.01%
Complexity 108 108
============================================
Files 255 255
Lines 5740 5739 -1
Branches 885 885
============================================
- Hits 4938 4937 -1
Misses 483 483
Partials 319 319
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1756?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1756/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `80.64% <100.00%> (-0.31%)` | `0.00 <0.00> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1756?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1756?src=pr&el=footer). Last update [5588258...9f9bc70](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1756?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org