You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "liming30 (via GitHub)" <gi...@apache.org> on 2023/03/29 07:47:48 UTC
[GitHub] [incubator-paimon] liming30 opened a new pull request, #761: [core][bug] fix the issue of failing to get table with timeTravel semantics from catalog (#731)
liming30 opened a new pull request, #761:
URL: https://github.com/apache/incubator-paimon/pull/761
### Purpose
[core][bug] fix the issue of failing to get table with timeTravel semantics from catalog (#731)
### Tests
The existing `FlinkCatalogTest` can already cover this change. I added the `scan.mode` configuration to `FlinkCatalogTest`.
### API and Format
No changes.
### Documentation
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi merged pull request #761: [core][bug] fix the issue of failing to get table with timeTravel semantics from catalog (#731)
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #761:
URL: https://github.com/apache/incubator-paimon/pull/761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] liming30 commented on a diff in pull request #761: [core][bug] fix the issue of failing to get table with timeTravel semantics from catalog (#731)
Posted by "liming30 (via GitHub)" <gi...@apache.org>.
liming30 commented on code in PR #761:
URL: https://github.com/apache/incubator-paimon/pull/761#discussion_r1155889628
##########
paimon-core/src/main/java/org/apache/paimon/table/FileStoreTableFactory.java:
##########
@@ -72,6 +72,11 @@ public static FileStoreTable create(FileIO fileIO, Path tablePath, TableSchema t
public static FileStoreTable create(
FileIO fileIO, Path tablePath, TableSchema tableSchema, Options dynamicOptions) {
FileStoreTable table;
+ tableSchema =
Review Comment:
Resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] liming30 commented on a diff in pull request #761: [core][bug] fix the issue of failing to get table with timeTravel semantics from catalog (#731)
Posted by "liming30 (via GitHub)" <gi...@apache.org>.
liming30 commented on code in PR #761:
URL: https://github.com/apache/incubator-paimon/pull/761#discussion_r1155889628
##########
paimon-core/src/main/java/org/apache/paimon/table/FileStoreTableFactory.java:
##########
@@ -72,6 +72,11 @@ public static FileStoreTable create(FileIO fileIO, Path tablePath, TableSchema t
public static FileStoreTable create(
FileIO fileIO, Path tablePath, TableSchema tableSchema, Options dynamicOptions) {
FileStoreTable table;
+ tableSchema =
Review Comment:
Thanks, resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi commented on pull request #761: [core][bug] fix the issue of failing to get table with timeTravel semantics from catalog (#731)
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #761:
URL: https://github.com/apache/incubator-paimon/pull/761#issuecomment-1489774178
Replied in issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #761: [core][bug] fix the issue of failing to get table with timeTravel semantics from catalog (#731)
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #761:
URL: https://github.com/apache/incubator-paimon/pull/761#discussion_r1155424491
##########
paimon-core/src/main/java/org/apache/paimon/table/FileStoreTableFactory.java:
##########
@@ -72,6 +72,11 @@ public static FileStoreTable create(FileIO fileIO, Path tablePath, TableSchema t
public static FileStoreTable create(
FileIO fileIO, Path tablePath, TableSchema tableSchema, Options dynamicOptions) {
FileStoreTable table;
+ tableSchema =
Review Comment:
Can we modify `AbstractFileStoreTable`?
```
public AbstractFileStoreTable(FileIO fileIO, Path path, TableSchema tableSchema) {
this.fileIO = fileIO;
this.path = path;
if (!tableSchema.options().containsKey(PATH.key())) {
// make sure table is always available
Map<String, String> newOptions = new HashMap<>(tableSchema.options());
newOptions.put(PATH.key(), path.toString());
tableSchema = tableSchema.copy(newOptions);
}
this.tableSchema = tableSchema;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org