You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Ignite TC Bot (Jira)" <ji...@apache.org> on 2021/04/09 09:55:00 UTC
[jira] [Commented] (IGNITE-14428) Formalize the names of the
metrics included in the metric registry.
[ https://issues.apache.org/jira/browse/IGNITE-14428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317836#comment-17317836 ]
Ignite TC Bot commented on IGNITE-14428:
----------------------------------------
{panel:title=Branch: [pull/8937/head] Base: [master] : No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/8937/head] Base: [master] : No new tests found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}{panel}
[TeamCity *--> Run :: All* Results|https://ci.ignite.apache.org/viewLog.html?buildId=5944058&buildTypeId=IgniteTests24Java8_RunAll]
> Formalize the names of the metrics included in the metric registry.
> --------------------------------------------------------------------
>
> Key: IGNITE-14428
> URL: https://issues.apache.org/jira/browse/IGNITE-14428
> Project: Ignite
> Issue Type: Improvement
> Reporter: Mikhail Petrov
> Assignee: Mikhail Petrov
> Priority: Major
> Labels: IEP-35
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> It's needed to refactor metric names to obey the global rule - all of them must start with name of the registry they belongs to. And add corresponding assertion.
> The purpose of this change is to make all metrics that belongs to one MetricRegistry have the name that obeys mentioned above rule regardless how they were registered. It helps to use a consistent approach to work with all metrics.
> The following metric names will be changed to obey this rule:
> JoinedNodes -> io.discovery.JoinedNodes
> LeftNodes -> io.discovery.LeftNodes
> FailedNodes -> io.discovery.FailedNodes
> PendingMessagesRegistered -> io.discovery.PendingMessagesRegistered
> CommunicationErrors -> io.discovery.CommunicationErrors
> CurrentTopologyVersion -> io.discovery.CurrentTopologyVersion
--
This message was sent by Atlassian Jira
(v8.3.4#803005)