You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by gaohoward <gi...@git.apache.org> on 2017/03/08 14:53:25 UTC

[GitHub] activemq-artemis pull request #1072: ARTEMIS-1024 Management operation cause...

GitHub user gaohoward opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1072

    ARTEMIS-1024 Management operation causes ClassNotFoundException

    Artemis expose createQueue() method to management console like Jon.
    If the queue to be created already exists it throws an ActiveMQException
    back to the console, which will get a ClassNotFoundException when
    deserializing the exception.
    
    To fix that it should throw a common java exception like IllegalStateException.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gaohoward/activemq-artemis master-mgmt-ex

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1072.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1072
    
----
commit 08ad1af0e0c70fbdbcd912478e21ae8b56f3c11f
Author: Howard Gao <ho...@gmail.com>
Date:   2017-03-08T14:50:33Z

    ARTEMIS-1024 Management operation causes ClassNotFoundException
    
    Artemis expose createQueue() method to management console like Jon.
    If the queue to be created already exists it throws an ActiveMQException
    back to the console, which will get a ClassNotFoundException when
    deserializing the exception.
    
    To fix that it should throw a common java exception like IllegalStateException.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1072: ARTEMIS-1024 Management operation causes Class...

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1072
  
    a problem with fixes without tests.. is that if I break this again later.. I won't know I broke it..
    
    
    is there a way you could add a test?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1072: ARTEMIS-1024 Management operation cause...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1072


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1072: ARTEMIS-1024 Management operation causes Class...

Posted by gaohoward <gi...@git.apache.org>.

Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1072
  
    Sure I'll add a test. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1072: ARTEMIS-1024 Management operation causes Class...

Posted by gaohoward <gi...@git.apache.org>.

Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1072
  
    @clebertsuconic Test added.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---