You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <an...@apache.org> on 2017/01/25 19:49:01 UTC
Review Request 55941: Modified existing tests to support new headers
for request streaming.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55941/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-6936
https://issues.apache.org/jira/browse/MESOS-6936
Repository: mesos
Description
-------
These tests now set the "Message-Accept", "Message-Content-Type"
headers correctly for streaming responses/requests.
Diffs
-----
src/tests/api_tests.cpp 400ac6fcd420508509291249cad50679fbe9807d
src/tests/containerizer/io_switchboard_tests.cpp 2e3cfe5003defdb5c46e770b54199d36be03c804
Diff: https://reviews.apache.org/r/55941/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 55941: Modified existing tests to support new
headers for request streaming.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55941/
-----------------------------------------------------------
(Updated Jan. 26, 2017, 4:50 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Review comments, NNFR.
Bugs: MESOS-6936
https://issues.apache.org/jira/browse/MESOS-6936
Repository: mesos
Description
-------
These tests now set the "Message-Accept", "Message-Content-Type"
headers correctly for streaming responses/requests.
Diffs (updated)
-----
src/tests/api_tests.cpp 400ac6fcd420508509291249cad50679fbe9807d
src/tests/containerizer/io_switchboard_tests.cpp 2e3cfe5003defdb5c46e770b54199d36be03c804
Diff: https://reviews.apache.org/r/55941/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 55941: Modified existing tests to support new
headers for request streaming.
Posted by Anand Mazumdar <an...@apache.org>.
> On Jan. 26, 2017, 1:11 a.m., Vinod Kone wrote:
> > src/tests/api_tests.cpp, line 4761
> > <https://reviews.apache.org/r/55941/diff/1/?file=1615317#file1615317line4761>
> >
> > you wanted to test the backwards compatibility here? i.e., setting accept to "application/json" and not "application/recordio".
yes, that was my intention.
- Anand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55941/#review163065
-----------------------------------------------------------
On Jan. 26, 2017, 4:50 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55941/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2017, 4:50 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6936
> https://issues.apache.org/jira/browse/MESOS-6936
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These tests now set the "Message-Accept", "Message-Content-Type"
> headers correctly for streaming responses/requests.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp 400ac6fcd420508509291249cad50679fbe9807d
> src/tests/containerizer/io_switchboard_tests.cpp 2e3cfe5003defdb5c46e770b54199d36be03c804
>
> Diff: https://reviews.apache.org/r/55941/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 55941: Modified existing tests to support new
headers for request streaming.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55941/#review163065
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/api_tests.cpp (line 4572)
<https://reviews.apache.org/r/55941/#comment234499>
headers
src/tests/api_tests.cpp (line 4757)
<https://reviews.apache.org/r/55941/#comment234500>
you wanted to test the backwards compatibility here? i.e., setting accept to "application/json" and not "application/recordio".
- Vinod Kone
On Jan. 25, 2017, 7:49 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55941/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2017, 7:49 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6936
> https://issues.apache.org/jira/browse/MESOS-6936
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These tests now set the "Message-Accept", "Message-Content-Type"
> headers correctly for streaming responses/requests.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp 400ac6fcd420508509291249cad50679fbe9807d
> src/tests/containerizer/io_switchboard_tests.cpp 2e3cfe5003defdb5c46e770b54199d36be03c804
>
> Diff: https://reviews.apache.org/r/55941/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>