You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Nguyen Truong <ng...@gmail.com> on 2018/08/22 09:03:51 UTC
Review Request 68470: SQOOP-3366 Improve unit tests to be able to
execute them in a single JVM
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68470/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-3366
https://issues.apache.org/jira/browse/SQOOP-3366
Repository: sqoop-trunk
Description
-------
Fix the unit tests which changed the state of the JVM so that other tests will not be affected when they are run on a single JVM.
Diffs
-----
src/test/org/apache/sqoop/TestFreeFormQueryImport.java d39faee55
src/test/org/apache/sqoop/TestIncrementalImport.java e1faf351f
src/test/org/apache/sqoop/TestSqoopOptions.java d0591ad0d
src/test/org/apache/sqoop/metastore/TestMetastoreConfigurationParameters.java 0f1eb890b
src/test/org/apache/sqoop/testutil/BaseSqoopTestCase.java 1730698e8
src/test/org/apache/sqoop/testutil/HsqldbTestServer.java c63a8f2dc
Diff: https://reviews.apache.org/r/68470/diff/1/
Testing
-------
No test has been added.
Thanks,
Nguyen Truong
Re: Review Request 68470: SQOOP-3366 Improve unit tests to be able to
execute them in a single JVM
Posted by Nguyen Truong <ng...@gmail.com>.
> On Aug. 23, 2018, 4:33 p.m., Szabolcs Vasas wrote:
> > Hi Nguyen,
> >
> > Thanks for submitting this patch!
> >
> > I have applied it, disabled the kerberized unit tests (TestKerberosAuthenticator, TestHiveMiniCluster, TestHiveServer2TextImport) and ./gradlew test ran successfully with forkEvery parameter set to 0.
> > The test execution time has reduced to 8.5 minutes from ~20 minutes!
Hi Szabolcs,
Thank you for commenting how you ran the tests. I should have showed how to test the code.
- Nguyen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68470/#review207818
-----------------------------------------------------------
On Aug. 23, 2018, 3:54 p.m., Nguyen Truong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68470/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2018, 3:54 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3366
> https://issues.apache.org/jira/browse/SQOOP-3366
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Fix the unit tests which changed the state of the JVM so that other tests will not be affected when they are run on a single JVM.
>
>
> Diffs
> -----
>
> src/test/org/apache/sqoop/TestIncrementalImport.java e1faf351f
> src/test/org/apache/sqoop/TestSqoopOptions.java d0591ad0d
> src/test/org/apache/sqoop/metastore/TestMetastoreConfigurationParameters.java 0f1eb890b
> src/test/org/apache/sqoop/testutil/BaseSqoopTestCase.java 1730698e8
> src/test/org/apache/sqoop/testutil/HsqldbTestServer.java c63a8f2dc
> src/test/org/apache/sqoop/tool/TestMainframeImportTool.java c2edc5347
>
>
> Diff: https://reviews.apache.org/r/68470/diff/3/
>
>
> Testing
> -------
>
> No test has been added.
>
>
> Thanks,
>
> Nguyen Truong
>
>
Re: Review Request 68470: SQOOP-3366 Improve unit tests to be able to
execute them in a single JVM
Posted by Szabolcs Vasas <va...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68470/#review207818
-----------------------------------------------------------
Ship it!
Hi Nguyen,
Thanks for submitting this patch!
I have applied it, disabled the kerberized unit tests (TestKerberosAuthenticator, TestHiveMiniCluster, TestHiveServer2TextImport) and ./gradlew test ran successfully with forkEvery parameter set to 0.
The test execution time has reduced to 8.5 minutes from ~20 minutes!
- Szabolcs Vasas
On Aug. 23, 2018, 3:54 p.m., Nguyen Truong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68470/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2018, 3:54 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3366
> https://issues.apache.org/jira/browse/SQOOP-3366
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Fix the unit tests which changed the state of the JVM so that other tests will not be affected when they are run on a single JVM.
>
>
> Diffs
> -----
>
> src/test/org/apache/sqoop/TestIncrementalImport.java e1faf351f
> src/test/org/apache/sqoop/TestSqoopOptions.java d0591ad0d
> src/test/org/apache/sqoop/metastore/TestMetastoreConfigurationParameters.java 0f1eb890b
> src/test/org/apache/sqoop/testutil/BaseSqoopTestCase.java 1730698e8
> src/test/org/apache/sqoop/testutil/HsqldbTestServer.java c63a8f2dc
> src/test/org/apache/sqoop/tool/TestMainframeImportTool.java c2edc5347
>
>
> Diff: https://reviews.apache.org/r/68470/diff/3/
>
>
> Testing
> -------
>
> No test has been added.
>
>
> Thanks,
>
> Nguyen Truong
>
>
Re: Review Request 68470: SQOOP-3366 Improve unit tests to be able to
execute them in a single JVM
Posted by Fero Szabo via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68470/#review207820
-----------------------------------------------------------
Ship it!
Ship It!
- Fero Szabo
On Aug. 23, 2018, 3:54 p.m., Nguyen Truong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68470/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2018, 3:54 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3366
> https://issues.apache.org/jira/browse/SQOOP-3366
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Fix the unit tests which changed the state of the JVM so that other tests will not be affected when they are run on a single JVM.
>
>
> Diffs
> -----
>
> src/test/org/apache/sqoop/TestIncrementalImport.java e1faf351f
> src/test/org/apache/sqoop/TestSqoopOptions.java d0591ad0d
> src/test/org/apache/sqoop/metastore/TestMetastoreConfigurationParameters.java 0f1eb890b
> src/test/org/apache/sqoop/testutil/BaseSqoopTestCase.java 1730698e8
> src/test/org/apache/sqoop/testutil/HsqldbTestServer.java c63a8f2dc
> src/test/org/apache/sqoop/tool/TestMainframeImportTool.java c2edc5347
>
>
> Diff: https://reviews.apache.org/r/68470/diff/3/
>
>
> Testing
> -------
>
> No test has been added.
>
>
> Thanks,
>
> Nguyen Truong
>
>
Re: Review Request 68470: SQOOP-3366 Improve unit tests to be able to
execute them in a single JVM
Posted by Nguyen Truong <ng...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68470/
-----------------------------------------------------------
(Updated Aug. 23, 2018, 3:54 p.m.)
Review request for Sqoop.
Changes
-------
Sorry, the previous one was not up-to-date with trunk.
Bugs: SQOOP-3366
https://issues.apache.org/jira/browse/SQOOP-3366
Repository: sqoop-trunk
Description
-------
Fix the unit tests which changed the state of the JVM so that other tests will not be affected when they are run on a single JVM.
Diffs (updated)
-----
src/test/org/apache/sqoop/TestIncrementalImport.java e1faf351f
src/test/org/apache/sqoop/TestSqoopOptions.java d0591ad0d
src/test/org/apache/sqoop/metastore/TestMetastoreConfigurationParameters.java 0f1eb890b
src/test/org/apache/sqoop/testutil/BaseSqoopTestCase.java 1730698e8
src/test/org/apache/sqoop/testutil/HsqldbTestServer.java c63a8f2dc
src/test/org/apache/sqoop/tool/TestMainframeImportTool.java c2edc5347
Diff: https://reviews.apache.org/r/68470/diff/3/
Changes: https://reviews.apache.org/r/68470/diff/2-3/
Testing
-------
No test has been added.
Thanks,
Nguyen Truong
Re: Review Request 68470: SQOOP-3366 Improve unit tests to be able to
execute them in a single JVM
Posted by Nguyen Truong <ng...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68470/
-----------------------------------------------------------
(Updated Aug. 23, 2018, 3:23 p.m.)
Review request for Sqoop.
Bugs: SQOOP-3366
https://issues.apache.org/jira/browse/SQOOP-3366
Repository: sqoop-trunk
Description
-------
Fix the unit tests which changed the state of the JVM so that other tests will not be affected when they are run on a single JVM.
Diffs (updated)
-----
src/test/org/apache/sqoop/TestIncrementalImport.java e1faf351f
src/test/org/apache/sqoop/TestSqoopOptions.java d0591ad0d
src/test/org/apache/sqoop/metastore/TestMetastoreConfigurationParameters.java 0f1eb890b
src/test/org/apache/sqoop/testutil/BaseSqoopTestCase.java 1730698e8
src/test/org/apache/sqoop/testutil/HsqldbTestServer.java c63a8f2dc
src/test/org/apache/sqoop/tool/TestMainframeImportTool.java 0b0c6c342
Diff: https://reviews.apache.org/r/68470/diff/2/
Changes: https://reviews.apache.org/r/68470/diff/1-2/
Testing
-------
No test has been added.
Thanks,
Nguyen Truong