You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2015/01/30 22:00:47 UTC

[GitHub] incubator-brooklyn pull request: Java 8 compile fixes

GitHub user neykov opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/498

    Java 8 compile fixes

    Problems are at places where generics are misused. Usually preceded by compiler warnings.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/neykov/incubator-brooklyn fix/java8-javac

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/498.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #498
    
----
commit 2498ce9742fa1a67c0e2904d92915c93b798b99c
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date:   2015-01-30T20:59:17Z

    Java 8 compile fixes

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Java 8 compile fixes

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/498


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Java 8 compile fixes

Posted by ahgittin <gi...@git.apache.org>.

Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/498#issuecomment-72341751
  
    works fine for me, and looks sensible -- merging
    
    most of these seem to be caused by java 8 not wanting a raw `Thing` passed to a function which wants a `Thing<WithGenerics>` -- is that correct?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Java 8 compile fixes

Posted by neykov <gi...@git.apache.org>.

Github user neykov commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/498#issuecomment-72375308
  
    The problem (with most of the spots) is passing a raw type which causes the return type to be erased. This by itself is not a problem, but if there are any chained methods, they are not resolved correctly.
    
    Looks like related to http://bugs.java.com/bugdatabase/view_bug.do?bug_id=7144506


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---