[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #7009: Fix issues around Database permissions

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #7009: Fix issues around Database permissions
URL: https://github.com/apache/incubator-superset/pull/7009#discussion_r264514728
 
 

 ##########
 File path: superset/security.py
 ##########
 @@ -410,8 +412,12 @@ def set_perm(self, mapper, connection, target):  # noqa
                 .values(perm=target.get_perm()),
             )
 
-        # add to view menu if not already exists
         permission_name = 'datasource_access'
+        from superset.models.core import Database
+        if mapper.class_ == Database:
 
 Review comment:
   FYI , `superset init` would create the proper `database_access` (one for each database), but the code here (executed on update/insert) would create/update a `datasource_access` entry for the database

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org