You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/11/23 23:13:11 UTC
[GitHub] [druid] techdocsmith opened a new pull request #11983: Docs: Add multi-dimension partitioning doc; refactor native batch and separate into smaller topics.
techdocsmith opened a new pull request #11983:
URL: https://github.com/apache/druid/pull/11983
Adds documentation for multi-dimension partitioning. cc: @kfaraz
Refactors the native batch partitioning topic as follows:
- Native batch ingestion covers `parallel-index`
- Native batch simple task indexing covers `index`
- Native batch input sources covers `ioSource`
- Native batch ingestion with firehose covers deprecated firehose
This PR has:
- [ x] been self-reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] kfaraz commented on a change in pull request #11983: Docs: Add multi-dimension partitioning doc; refactor native batch and separate into smaller topics.
Posted by GitBox <gi...@apache.org>.
kfaraz commented on a change in pull request #11983:
URL: https://github.com/apache/druid/pull/11983#discussion_r755677044
##########
File path: docs/ingestion/native-batch-simple-task.md
##########
@@ -0,0 +1,182 @@
+---
+id: native-batch-simple-task
+title: "Native batch simple task indexing"
+sidebar_label: "Simple task indexing"
+---
+
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+
+The simple task (type `index`) is designed to to ingest small data sets into Apache Druid. The task executes within the indexing service. For information general information on native batch indexing and parallel task indexing, see [Native batch ingestion](./native-batch.md).
+
+### Task syntax
+
+A sample task is shown below:
+
+```json
+{
+ "type" : "index",
+ "spec" : {
+ "dataSchema" : {
+ "dataSource" : "wikipedia",
+ "timestampSpec" : {
+ "column" : "timestamp",
+ "format" : "auto"
+ },
+ "dimensionsSpec" : {
+ "dimensions": ["page","language","user","unpatrolled","newPage","robot","anonymous","namespace","continent","country","region","city"],
+ "dimensionExclusions" : []
+ },
+ "metricsSpec" : [
+ {
+ "type" : "count",
+ "name" : "count"
+ },
+ {
+ "type" : "doubleSum",
+ "name" : "added",
+ "fieldName" : "added"
+ },
+ {
+ "type" : "doubleSum",
+ "name" : "deleted",
+ "fieldName" : "deleted"
+ },
+ {
+ "type" : "doubleSum",
+ "name" : "delta",
+ "fieldName" : "delta"
+ }
+ ],
+ "granularitySpec" : {
+ "type" : "uniform",
+ "segmentGranularity" : "DAY",
+ "queryGranularity" : "NONE",
+ "intervals" : [ "2013-08-31/2013-09-01" ]
+ }
+ },
+ "ioConfig" : {
+ "type" : "index",
+ "inputSource" : {
+ "type" : "local",
+ "baseDir" : "examples/indexing/",
+ "filter" : "wikipedia_data.json"
+ },
+ "inputFormat": {
+ "type": "json"
+ }
+ },
+ "tuningConfig" : {
Review comment:
I think this should contain a `partitionsSpec` as some of these fields like `maxRowsPerSegment` are deprecated, as described in the `tuningConfig` table below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] sthetland commented on a change in pull request #11983: Docs: Add multi-dimension partitioning doc; refactor native batch and separate into smaller topics.
Posted by GitBox <gi...@apache.org>.
sthetland commented on a change in pull request #11983:
URL: https://github.com/apache/druid/pull/11983#discussion_r756291340
##########
File path: docs/ingestion/native-batch-simple-task.md
##########
@@ -0,0 +1,182 @@
+---
+id: native-batch-simple-task
+title: "Native batch simple task indexing"
+sidebar_label: "Simple task indexing"
+---
+
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+
+The simple task (type `index`) is designed to to ingest small data sets into Apache Druid. The task executes within the indexing service. For information general information on native batch indexing and parallel task indexing, see [Native batch ingestion](./native-batch.md).
Review comment:
```suggestion
The simple task (type `index`) is designed to ingest small data sets into Apache Druid. The task executes within the indexing service. For general information on native batch indexing and parallel task indexing, see [Native batch ingestion](./native-batch.md).
```
##########
File path: docs/ingestion/native-batch-input-source.md
##########
@@ -0,0 +1,738 @@
+---
+id: native-batch-input-sources
+title: "Native batch input sources"
+sidebar_label: "Input sources"
+---
+
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+
+The input source is the place to define from where your index task reads data for Apache Druid native batch ingestion. Only the native parallel task and simple task support the input source.
+
+For information general information on native batch indexing and parallel task indexing, see [Native batch ingestion](./native-batch.md).
+
+> Firehose input has been deprecated. For information, see [Firehose](./native-batch-firehose.md).
Review comment:
Do we need to say this here? ("Firehose" doesn't otherwise appear in this page. )
##########
File path: docs/ingestion/native-batch-input-source.md
##########
@@ -0,0 +1,738 @@
+---
+id: native-batch-input-sources
+title: "Native batch input sources"
+sidebar_label: "Input sources"
+---
+
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+
+The input source is the place to define from where your index task reads data for Apache Druid native batch ingestion. Only the native parallel task and simple task support the input source.
+
+For information general information on native batch indexing and parallel task indexing, see [Native batch ingestion](./native-batch.md).
Review comment:
```suggestion
For general information on native batch indexing and parallel task indexing, see [Native batch ingestion](./native-batch.md).
```
##########
File path: docs/ingestion/native-batch.md
##########
@@ -642,6 +632,14 @@ An example of the result is
Returns the task attempt history of the worker task spec of the given id, or HTTP 404 Not Found error if the supervisor task is running in the sequential mode.
+### Segment pushing modes
+While ingesting data using the parallel task indexing, Druid creates segments from the input data and pushes them. For segment pushing,
+the parallel task index supports the following segment pushing modes based upon your type of [rollup](./rollup.md):
+
+- Bulk pushing mode: Used for perfect rollup. Druid pushes every segment at the very end of the index task. Until then, Druid stores created segments in memory and local storage of the service running the index task. This mode can cause problems if you have limited storage capacity, and is not recommended to use in production.
+To enable bulk pushing mode, set `forceGuaranteedRollup` in your TuningConfig. You can not use bulk pushing with `appendToExisting` in your IOConfig.
Review comment:
```suggestion
To enable bulk pushing mode, set `forceGuaranteedRollup` in your TuningConfig. You cannot use bulk pushing with `appendToExisting` in your IOConfig.
```
##########
File path: docs/ingestion/native-batch-simple-task.md
##########
@@ -0,0 +1,182 @@
+---
+id: native-batch-simple-task
+title: "Native batch simple task indexing"
+sidebar_label: "Simple task indexing"
+---
+
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+
+The simple task (type `index`) is designed to to ingest small data sets into Apache Druid. The task executes within the indexing service. For information general information on native batch indexing and parallel task indexing, see [Native batch ingestion](./native-batch.md).
+
+### Task syntax
Review comment:
Same as other file.... -1 to heading levels for all headings
```suggestion
## Task syntax
```
##########
File path: docs/ingestion/native-batch-input-source.md
##########
@@ -0,0 +1,738 @@
+---
+id: native-batch-input-sources
+title: "Native batch input sources"
+sidebar_label: "Input sources"
+---
+
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+
+The input source is the place to define from where your index task reads data for Apache Druid native batch ingestion. Only the native parallel task and simple task support the input source.
Review comment:
optional, just to tighten it a bit..
```suggestion
The input source defines where your index task reads data for Apache Druid native batch ingestion. Only the native parallel task and simple task support the input source.
```
##########
File path: docs/ingestion/native-batch.md
##########
@@ -414,6 +381,29 @@ them to create the final segments. Finally, they push the final segments to the
> in `partial dimension distribution` and `partial segment generation` phases,
> the task may fail if the input changes in between the two passes.
+#### Multi-dimension range partitioning
+> Multiple dimension (multi-dimension) range partitioning is an experimental feature. Multi-dimension range partitioning is currently not supported in the sequential mode of the Parallel task.
+
+When you use multi-dimension partitioning for your data, Druid is able to distribute segment sizes more evenly than with single dimension partitioning.
+
+For segment pruning to be effective and translate into better query performance, you must the first of your `partitionDimensions` at query time. For example, given the following `partitionDimensions`:
Review comment:
I think a word(s) is missing here, but not sure what it should be: "...you must __ the first..."
##########
File path: docs/ingestion/native-batch-firehose.md
##########
@@ -0,0 +1,341 @@
+---
+id: native-batch-firehose
Review comment:
Looks like the sidebar.json update is missing. (These new pages aren't in the left nav.)
##########
File path: docs/ingestion/native-batch-input-source.md
##########
@@ -0,0 +1,738 @@
+---
+id: native-batch-input-sources
+title: "Native batch input sources"
+sidebar_label: "Input sources"
+---
+
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+
+The input source is the place to define from where your index task reads data for Apache Druid native batch ingestion. Only the native parallel task and simple task support the input source.
+
+For information general information on native batch indexing and parallel task indexing, see [Native batch ingestion](./native-batch.md).
+
+> Firehose input has been deprecated. For information, see [Firehose](./native-batch-firehose.md).
+
+## S3 input source
+
+> You need to include the [`druid-s3-extensions`](../development/extensions-core/s3.md) as an extension to use the S3 input source.
+
+The S3 input source is to support reading objects directly from S3.
+Objects can be specified either via a list of S3 URI strings or a list of
+S3 location prefixes, which will attempt to list the contents and ingest
+all objects contained in the locations. The S3 input source is splittable
+and can be used by the [Parallel task](./native-batch.md),
+where each worker task of `index_parallel` will read one or multiple objects.
+
+Sample specs:
+
+```json
+...
+ "ioConfig": {
+ "type": "index_parallel",
+ "inputSource": {
+ "type": "s3",
+ "uris": ["s3://foo/bar/file.json", "s3://bar/foo/file2.json"]
+ },
+ "inputFormat": {
+ "type": "json"
+ },
+ ...
+ },
+...
+```
+
+```json
+...
+ "ioConfig": {
+ "type": "index_parallel",
+ "inputSource": {
+ "type": "s3",
+ "prefixes": ["s3://foo/bar/", "s3://bar/foo/"]
+ },
+ "inputFormat": {
+ "type": "json"
+ },
+ ...
+ },
+...
+```
+
+
+```json
+...
+ "ioConfig": {
+ "type": "index_parallel",
+ "inputSource": {
+ "type": "s3",
+ "objects": [
+ { "bucket": "foo", "path": "bar/file1.json"},
+ { "bucket": "bar", "path": "foo/file2.json"}
+ ]
+ },
+ "inputFormat": {
+ "type": "json"
+ },
+ ...
+ },
+...
+```
+
+```json
+...
+ "ioConfig": {
+ "type": "index_parallel",
+ "inputSource": {
+ "type": "s3",
+ "uris": ["s3://foo/bar/file.json", "s3://bar/foo/file2.json"],
+ "properties": {
+ "accessKeyId": "KLJ78979SDFdS2",
+ "secretAccessKey": "KLS89s98sKJHKJKJH8721lljkd"
+ }
+ },
+ "inputFormat": {
+ "type": "json"
+ },
+ ...
+ },
+...
+```
+
+```json
+...
+ "ioConfig": {
+ "type": "index_parallel",
+ "inputSource": {
+ "type": "s3",
+ "uris": ["s3://foo/bar/file.json", "s3://bar/foo/file2.json"],
+ "properties": {
+ "accessKeyId": "KLJ78979SDFdS2",
+ "secretAccessKey": "KLS89s98sKJHKJKJH8721lljkd",
+ "assumeRoleArn": "arn:aws:iam::2981002874992:role/role-s3"
+ }
+ },
+ "inputFormat": {
+ "type": "json"
+ },
+ ...
+ },
+...
+```
+
+|property|description|default|required?|
+|--------|-----------|-------|---------|
+|type|This should be `s3`.|None|yes|
+|uris|JSON array of URIs where S3 objects to be ingested are located.|None|`uris` or `prefixes` or `objects` must be set|
+|prefixes|JSON array of URI prefixes for the locations of S3 objects to be ingested. Empty objects starting with one of the given prefixes will be skipped.|None|`uris` or `prefixes` or `objects` must be set|
+|objects|JSON array of S3 Objects to be ingested.|None|`uris` or `prefixes` or `objects` must be set|
+|properties|Properties Object for overriding the default S3 configuration. See below for more information.|None|No (defaults will be used if not given)
+
+Note that the S3 input source will skip all empty objects only when `prefixes` is specified.
+
+S3 Object:
+
+|property|description|default|required?|
+|--------|-----------|-------|---------|
+|bucket|Name of the S3 bucket|None|yes|
+|path|The path where data is located.|None|yes|
+
+Properties Object:
+
+|property|description|default|required?|
+|--------|-----------|-------|---------|
+|accessKeyId|The [Password Provider](../operations/password-provider.md) or plain text string of this S3 InputSource's access key|None|yes if secretAccessKey is given|
+|secretAccessKey|The [Password Provider](../operations/password-provider.md) or plain text string of this S3 InputSource's secret key|None|yes if accessKeyId is given|
+|assumeRoleArn|AWS ARN of the role to assume [see](https://docs.aws.amazon.com/IAM/latest/UserGuide/id_credentials_temp_request.html). **assumeRoleArn** can be used either with the ingestion spec AWS credentials or with the default S3 credentials|None|no|
+|assumeRoleExternalId|A unique identifier that might be required when you assume a role in another account [see](https://docs.aws.amazon.com/IAM/latest/UserGuide/id_credentials_temp_request.html)|None|no|
+
+**Note :** *If accessKeyId and secretAccessKey are not given, the default [S3 credentials provider chain](../development/extensions-core/s3.md#s3-authentication-methods) is used.*
Review comment:
just while we're here, can't resist... Still not ideal, but making it match other notes on this page
```suggestion
> **Note:** If `accessKeyId` and `secretAccessKey` are not given, the default [S3 credentials provider chain](../development/extensions-core/s3.md#s3-authentication-methods) is used.
```
##########
File path: docs/ingestion/native-batch-input-source.md
##########
@@ -0,0 +1,738 @@
+---
+id: native-batch-input-sources
+title: "Native batch input sources"
+sidebar_label: "Input sources"
+---
+
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+
+The input source is the place to define from where your index task reads data for Apache Druid native batch ingestion. Only the native parallel task and simple task support the input source.
+
+For information general information on native batch indexing and parallel task indexing, see [Native batch ingestion](./native-batch.md).
+
+> Firehose input has been deprecated. For information, see [Firehose](./native-batch-firehose.md).
+
+## S3 input source
+
+> You need to include the [`druid-s3-extensions`](../development/extensions-core/s3.md) as an extension to use the S3 input source.
+
+The S3 input source is to support reading objects directly from S3.
Review comment:
For another PR, but this wording has always seemed off. It could just be "The S3 input source supports reading..." or just "The S3 input source reads objects directly..."
By the way, I'm scanning but not otherwise closely reading these sections, on assumption that there aren't content changes. Let me know if not.
##########
File path: docs/ingestion/native-batch-firehose.md
##########
@@ -0,0 +1,341 @@
+---
+id: native-batch-firehose
+title: "Native batch ingestion with firehose"
+sidebar_label: "Firehose"
+---
+
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+
+
+Firehoses are deprecated in 0.17.0. It's highly recommended to use the [Native batch ingestion input sources](./native-batch-input-source.md) instead.
+
+There are several firehoses readily available in Druid, some are meant for examples, others can be used directly in a production environment.
+
+### StaticS3Firehose
Review comment:
Raising this heading level by one, but they should all be adjusted to match. (Note to selves: the right hand page TOC doesn't appear if headings don't start at level 2 or 1. )
```suggestion
## StaticS3Firehose
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 merged pull request #11983: Docs: Add multi-dimension partitioning doc; refactor native batch and separate into smaller topics.
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 merged pull request #11983:
URL: https://github.com/apache/druid/pull/11983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] loquisgon commented on pull request #11983: Docs: Add multi-dimension partitioning doc; refactor native batch and separate into smaller topics.
Posted by GitBox <gi...@apache.org>.
loquisgon commented on pull request #11983:
URL: https://github.com/apache/druid/pull/11983#issuecomment-987505238
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org