You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@training.apache.org by Sharan Foga <sh...@apache.org> on 2020/05/24 09:39:10 UTC

Pull Request for new ComDev Directory

Hi All

I'm fairly new to using git so am being extra cautious not to break anything. I've created the new ComDev directory and tested it locally by adding an introduction presentation I gave last year, and it is working. 

I've created my very first pull request so am happy to get any feedback that will help me get up to speed :-)

Thanks
Sharan

Re: Pull Request for new ComDev Directory

Posted by Sharan Foga <sh...@apache.org>.

Hi

Big thanks to Gautam and Ryan for the reviews. I've done the updates as suggested so if you are happy then please merge.

Thanks
Sharan

On 2020/05/25 15:25:53, sharanf <sh...@apache.org> wrote: 
> HI Gautam
> 
> Thanks for the review. I'll take a look and correct them.
> 
> Thanks
> Sharan
> 
> On 2020-05-25 01:37, gautam gupta wrote:
> > Hey Sharan,
> > I have reviewed your presentation. It looks good.
> >
> > There are some minor Typos. I think if you run a spell check on it, you can
> > catch many of these.
> >
> > thanks,
> > Gautam
> >
> > On Sun, May 24, 2020 at 2:39 AM Sharan Foga <sh...@apache.org> wrote:
> >
> >> Hi All
> >>
> >> I'm fairly new to using git so am being extra cautious not to break
> >> anything. I've created the new ComDev directory and tested it locally by
> >> adding an introduction presentation I gave last year, and it is working.
> >>
> >> I've created my very first pull request so am happy to get any feedback
> >> that will help me get up to speed :-)
> >>
> >> Thanks
> >> Sharan
> >>
> 
>

Re: Pull Request for new ComDev Directory

Posted by sharanf <sh...@apache.org>.

HI Gautam

Thanks for the review. I'll take a look and correct them.

Thanks
Sharan

On 2020-05-25 01:37, gautam gupta wrote:
> Hey Sharan,
> I have reviewed your presentation. It looks good.
>
> There are some minor Typos. I think if you run a spell check on it, you can
> catch many of these.
>
> thanks,
> Gautam
>
> On Sun, May 24, 2020 at 2:39 AM Sharan Foga <sh...@apache.org> wrote:
>
>> Hi All
>>
>> I'm fairly new to using git so am being extra cautious not to break
>> anything. I've created the new ComDev directory and tested it locally by
>> adding an introduction presentation I gave last year, and it is working.
>>
>> I've created my very first pull request so am happy to get any feedback
>> that will help me get up to speed :-)
>>
>> Thanks
>> Sharan
>>

Re: Pull Request for new ComDev Directory

Posted by gautam gupta <gr...@gmail.com>.

Hey Sharan,
I have reviewed your presentation. It looks good.

There are some minor Typos. I think if you run a spell check on it, you can
catch many of these.

thanks,
Gautam

On Sun, May 24, 2020 at 2:39 AM Sharan Foga <sh...@apache.org> wrote:

> Hi All
>
> I'm fairly new to using git so am being extra cautious not to break
> anything. I've created the new ComDev directory and tested it locally by
> adding an introduction presentation I gave last year, and it is working.
>
> I've created my very first pull request so am happy to get any feedback
> that will help me get up to speed :-)
>
> Thanks
> Sharan
>