You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "kaijchen (via GitHub)" <gi...@apache.org> on 2023/03/17 02:42:35 UTC
[GitHub] [incubator-uniffle] kaijchen opened a new pull request, #734: [#733] test: fix LocalStorageManagerTest#testGetLocalStorageInfo on SSD system
kaijchen opened a new pull request, #734:
URL: https://github.com/apache/incubator-uniffle/pull/734
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
Assert local storage info to be any of `HDD` or `SSD`.
### Why are the changes needed?
Fix: #733
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Tested on Linux system with SSD.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen merged pull request #734: [#733] test: fix LocalStorageManagerTest#testGetLocalStorageInfo on Linux SSD platform
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen merged PR #734:
URL: https://github.com/apache/incubator-uniffle/pull/734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #734: [#733] test: fix LocalStorageManagerTest#testGetLocalStorageInfo on SSD system
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #734:
URL: https://github.com/apache/incubator-uniffle/pull/734#issuecomment-1473041798
## [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/734?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#734](https://codecov.io/gh/apache/incubator-uniffle/pull/734?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a1e2272) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/ea4f8c4770357048fbdbcfb8ee546223a98f91ff?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ea4f8c4) will **increase** coverage by `1.21%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #734 +/- ##
============================================
+ Coverage 60.63% 61.85% +1.21%
+ Complexity 1850 1764 -86
============================================
Files 229 207 -22
Lines 12749 10312 -2437
Branches 1064 1030 -34
============================================
- Hits 7730 6378 -1352
+ Misses 4609 3593 -1016
+ Partials 410 341 -69
```
[see 29 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-uniffle/pull/734/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org