You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by "Alex Heneveld (JIRA)" <ji...@apache.org> on 2016/02/24 23:15:18 UTC
[jira] [Commented] (BROOKLYN-206) Unreliable test:
AbstractControllerTest.testUpdateCalledWhenChildHostnameAndPortChanges
[ https://issues.apache.org/jira/browse/BROOKLYN-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163903#comment-15163903 ]
Alex Heneveld commented on BROOKLYN-206:
----------------------------------------
i (alex) don't understand how this is happening. probably optimistic but maybe it is fixed. if not we'll need the debug logs to see what is happening.
i've confirmed:
* the policy is attached and active during setup, before start completes
* the child is added as a member synchronously
* the policy which is "subscribed to members" is in fact subscribed to everything
then filtered for members, not ideal, but there shouldn't be a race in the policy getting notices
* the handling of those events are both processed in order and look up the current values
rather than relying on the published values; either should be sufficient to cause the addresses to change
there was a sleep(100) marked "Ugly sleep to allow AbstractController to detect node having been added"
from the test's addition by aled in early 2014, but can't see why that would be necessary
> Unreliable test: AbstractControllerTest.testUpdateCalledWhenChildHostnameAndPortChanges
> ---------------------------------------------------------------------------------------
>
> Key: BROOKLYN-206
> URL: https://issues.apache.org/jira/browse/BROOKLYN-206
> Project: Brooklyn
> Issue Type: Bug
> Reporter: Sam Corbett
>
> Stacktrace
> {code}
> java.lang.AssertionError: expected [true] but found [false]
> at org.testng.Assert.fail(Assert.java:94)
> at org.testng.Assert.failNotEquals(Assert.java:494)
> at org.testng.Assert.assertTrue(Assert.java:42)
> at org.testng.Assert.assertTrue(Assert.java:52)
> at org.apache.brooklyn.entity.proxy.AbstractControllerTest.assertAddressesMatch(AbstractControllerTest.java:308)
> at org.apache.brooklyn.entity.proxy.AbstractControllerTest.access$100(AbstractControllerTest.java:67)
> {code}
> Debug log
> {code}
> 2015-12-15 15:30:17,853 INFO TESTNG INVOKING CONFIGURATION: "Surefire test" - @BeforeMethod org.apache.brooklyn.entity.proxy.AbstractControllerTest.setUp()
> 2015-12-15 15:30:18,096 INFO Starting TrackingAbstractControllerImpl{id=Zveoz16x}, obtaining a new location instance in FixedListMachineProvisioningLocation{id=HsQneYPD, name=FixedListMachineProvisioningLocation:HsQn} with ports [22, 8000, 8443]
> 2015-12-15 15:30:18,108 INFO Starting TrackingAbstractControllerImpl{id=Zveoz16x} on machine SshMachineLocation[SshMachineLocation:TM32:null@/1.1.1.1:22(id=TM32DuVH)]
> 2015-12-15 15:30:18,242 INFO Added policy ServerPoolMemberTrackerPolicy{name=Controller targets tracker, running=true} to TrackingAbstractControllerImpl{id=Zveoz16x}
> 2015-12-15 15:30:18,242 INFO Resetting TrackingAbstractControllerImpl{id=Zveoz16x}, server pool targets {}
> 2015-12-15 15:30:18,244 INFO Updating TrackingAbstractControllerImpl{id=Zveoz16x}, server pool targets {}
> 2015-12-15 15:30:18,244 INFO test controller reconfigure, targets []
> 2015-12-15 15:30:18,252 INFO TESTNG PASSED CONFIGURATION: "Surefire test" - @BeforeMethod org.apache.brooklyn.entity.proxy.AbstractControllerTest.setUp() finished in 399 ms
> 2015-12-15 15:30:18,253 INFO TESTNG INVOKING: "Surefire test" - org.apache.brooklyn.entity.proxy.AbstractControllerTest.testUpdateCalledWhenChildHostnameAndPortChanges()
> 2015-12-15 15:30:33,398 INFO succeedsEventually exceeded max attempts or timeout - 39 attempts lasting 15001 ms, for RunnableAdapter(org.apache.brooklyn.entity.proxy.AbstractControllerTest$3@186540e1)
> 2015-12-15 15:30:33,398 INFO failed succeeds-eventually, 39 attempts, 15001ms elapsed (rethrowing): java.lang.AssertionError: expected [true] but found [false]
> 2015-12-15 15:30:33,401 INFO TESTNG FAILED: "Surefire test" - org.apache.brooklyn.entity.proxy.AbstractControllerTest.testUpdateCalledWhenChildHostnameAndPortChanges() finished in 15147 ms
> java.lang.AssertionError: expected [true] but found [false]
> at org.apache.brooklyn.entity.proxy.AbstractControllerTest.assertAddressesMatch(AbstractControllerTest.java:308)
> at org.apache.brooklyn.entity.proxy.AbstractControllerTest.access$100(AbstractControllerTest.java:67)
> at org.apache.brooklyn.entity.proxy.AbstractControllerTest$3.run(AbstractControllerTest.java:300)
> at org.apache.brooklyn.test.Asserts$RunnableAdapter.call(Asserts.java:1208)
> at org.apache.brooklyn.test.Asserts.succeedsEventually(Asserts.java:870)
> at org.apache.brooklyn.test.Asserts.succeedsEventually(Asserts.java:797)
> at org.apache.brooklyn.entity.proxy.AbstractControllerTest.assertEventuallyExplicitAddressesMatch(AbstractControllerTest.java:298)
> at org.apache.brooklyn.entity.proxy.AbstractControllerTest.testUpdateCalledWhenChildHostnameAndPortChanges(AbstractControllerTest.java:120)
> 2015-12-15 15:30:33,406 INFO TESTNG INVOKING CONFIGURATION: "Surefire test" - @AfterMethod org.apache.brooklyn.core.test.BrooklynMgmtUnitTestSupport.tearDown()
> 2015-12-15 15:30:33,417 INFO Stopping TrackingAbstractControllerImpl{id=Zveoz16x} in [SshMachineLocation[SshMachineLocation:TM32:null@1.1.1.1/1.1.1.1:22(id=TM32DuVH)]]
> 2015-12-15 15:30:33,460 INFO TESTNG PASSED CONFIGURATION: "Surefire test" - @AfterMethod org.apache.brooklyn.core.test.BrooklynMgmtUnitTestSupport.tearDown() finished in 55 ms
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)