[GitHub] kangpinghuang commented on a change in pull request #510: Be refactor optimize rowset

[GitBox <gi...@apache.org>]

kangpinghuang commented on a change in pull request #510: Be refactor optimize rowset
URL: https://github.com/apache/incubator-doris/pull/510#discussion_r246344983
 
 

 ##########
 File path: be/src/olap/rowset/alpha_rowset.cpp
 ##########
 @@ -52,11 +52,7 @@ OLAPStatus AlphaRowset::init() {
 }
 
 std::unique_ptr<RowsetReader> AlphaRowset::create_reader() {
-    std::vector<SegmentGroup*> segment_groups;
-    for (auto& segment_group : _segment_groups) {
-        segment_groups.push_back(segment_group.get());
-    }
-    return std::unique_ptr<RowsetReader>(new AlphaRowsetReader(_tablet_schema,
+    return std::unique_ptr<RowsetReader>(new AlphaRowsetReader(
 
 Review comment:
   unique_ptr can be used as returned value

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org