[GitHub] [ozone] smengcl commented on pull request #4567: HDDS-8528. [Snapshot] Custom SnapshotCache implementation to replace LoadingCache

["smengcl (via GitHub)" <gi...@apache.org>]

smengcl commented on PR #4567:
URL: https://github.com/apache/ozone/pull/4567#issuecomment-1535481836

   > > @hemantk-12
   > > > I don't see cacheSize is used in eviction policy if cache is full. Yes, it doesn't proactively claims some entries but only if they are not used by anyone. If it need bounded, cache it doesn't solve that problem.
   > > 
   > > 
   > > It does seem to be implemented here, or am I misunderstanding your point?
   > > https://github.com/apache/ozone/blob/ddfc4b738d6d48ef37f3af41a7f743247933e30a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotCache.java#L167-L174
   > 
   > I had the same impression when I look at it first time but it is not bounded because `cleanup()` is called only by `release()`.
   
   Thanks for the reminder. It needs to call `cleanup()` by the end of `get()` as well. I will push the change later. (Doesn't change the fact that the cache is still unbounded.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org