You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/06/15 20:46:28 UTC
Review Request 67615: Modified `createStrippedScalarQuantity()` to
clear all metadata fields.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67615/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler, Kapil Arya, and Till Toenshoff.
Repository: mesos
Description
-------
Currently `createStrippedScalarQuantity()` strips resource meta-data
except revocable and turns dynamic reservation into static reservation.
However, no current code depends on this behavior and this leads to
boilerplate code around call sites and performance overhead.
This patch further clears the above meta-data for simplicity
and performance.
Diffs
-----
include/mesos/resources.hpp 7afe0d8090a5075faed22bd408310ae1bb464bce
include/mesos/v1/resources.hpp c7120575d0dbfb9f8c9bb6b0cf9a4cea3d9f6932
src/common/resources.cpp b1392012702865e39d17b8715747582529cbccca
src/master/allocator/mesos/hierarchical.cpp b558228290e5ae6dbcc1b8a6e1fe69db9fd5874c
src/tests/resources_tests.cpp 2da583615ac8a8fb238f4996fe661343b718bad1
src/tests/sorter_tests.cpp 9cdffd778967bca3d0055be8a04fbb702432e59d
src/v1/resources.cpp 50793271ea9b3013aa5b4dcd95f329db81dff4d8
Diff: https://reviews.apache.org/r/67615/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 67615: Modified `createStrippedScalarQuantity()`
to clear all metadata fields.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67615/#review204897
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67561, 67615]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 15, 2018, 1:46 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67615/
> -----------------------------------------------------------
>
> (Updated June 15, 2018, 1:46 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Kapil Arya, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently `createStrippedScalarQuantity()` strips resource meta-data
> except revocable and turns dynamic reservation into static reservation.
> However, no current code depends on this behavior and this leads to
> boilerplate code around call sites and performance overhead.
>
> This patch further clears the above meta-data for simplicity
> and performance.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 7afe0d8090a5075faed22bd408310ae1bb464bce
> include/mesos/v1/resources.hpp c7120575d0dbfb9f8c9bb6b0cf9a4cea3d9f6932
> src/common/resources.cpp b1392012702865e39d17b8715747582529cbccca
> src/master/allocator/mesos/hierarchical.cpp b558228290e5ae6dbcc1b8a6e1fe69db9fd5874c
> src/tests/resources_tests.cpp 2da583615ac8a8fb238f4996fe661343b718bad1
> src/tests/sorter_tests.cpp 9cdffd778967bca3d0055be8a04fbb702432e59d
> src/v1/resources.cpp 50793271ea9b3013aa5b4dcd95f329db81dff4d8
>
>
> Diff: https://reviews.apache.org/r/67615/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 67615: Modified `createStrippedScalarQuantity()`
to clear all metadata fields.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67615/#review204882
-----------------------------------------------------------
PASS: Mesos patch 67615 was successfully built and tested.
Reviews applied: `['67561', '67615']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67615
- Mesos Reviewbot Windows
On June 15, 2018, 8:46 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67615/
> -----------------------------------------------------------
>
> (Updated June 15, 2018, 8:46 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Kapil Arya, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently `createStrippedScalarQuantity()` strips resource meta-data
> except revocable and turns dynamic reservation into static reservation.
> However, no current code depends on this behavior and this leads to
> boilerplate code around call sites and performance overhead.
>
> This patch further clears the above meta-data for simplicity
> and performance.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 7afe0d8090a5075faed22bd408310ae1bb464bce
> include/mesos/v1/resources.hpp c7120575d0dbfb9f8c9bb6b0cf9a4cea3d9f6932
> src/common/resources.cpp b1392012702865e39d17b8715747582529cbccca
> src/master/allocator/mesos/hierarchical.cpp b558228290e5ae6dbcc1b8a6e1fe69db9fd5874c
> src/tests/resources_tests.cpp 2da583615ac8a8fb238f4996fe661343b718bad1
> src/tests/sorter_tests.cpp 9cdffd778967bca3d0055be8a04fbb702432e59d
> src/v1/resources.cpp 50793271ea9b3013aa5b4dcd95f329db81dff4d8
>
>
> Diff: https://reviews.apache.org/r/67615/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>