[GitHub] [iceberg] rdblue commented on a diff in pull request #4649: Flink 1.14: Implement LookupTableSource for IcebergTableSource

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #4649:
URL: https://github.com/apache/iceberg/pull/4649#discussion_r861963634


##########
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/FlinkDynamicTableFactory.java:
##########
@@ -142,6 +143,12 @@ public Set<ConfigOption<?>> optionalOptions() {
     Set<ConfigOption<?>> options = Sets.newHashSet();
     options.add(CATALOG_DATABASE);
     options.add(CATALOG_TABLE);
+    options.add(FlinkLookupOptions.LOOKUP_CACHE_MAX_ROWS);
+    options.add(FlinkLookupOptions.LOOKUP_CACHE_TTL);
+    options.add(FlinkLookupOptions.LOOKUP_CACHE_IGNORE_EMPTY);
+    options.add(FlinkLookupOptions.LOOKUP_MAX_RETRIES);
+    options.add(FlinkLookupOptions.LOOKUP_BASE_RETRY_BACKOFF_MILLS);
+    options.add(FlinkLookupOptions.LOOKUP_MAX_RETRY_BACKOFF_MILLS);

Review Comment:
   Can we separate caching from the lookup source implementation?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org