[GitHub] [solr] madrob commented on a change in pull request #253: SOLR-15580: Allow setting the base work directory to another location…

[GitBox <gi...@apache.org>]

madrob commented on a change in pull request #253:
URL: https://github.com/apache/solr/pull/253#discussion_r718864578



##########
File path: solr/benchmark/src/java/org/apache/solr/bench/MiniClusterState.java
##########
@@ -180,31 +184,31 @@ public void metricsEnabled(boolean metricsEnabled) {
     }
 
     public void startMiniCluster(int nodeCount) {
-      log("starting mini cluster at base directory: " + baseDir.toAbsolutePath());
+      log("starting mini cluster at base directory: " + miniClusterBaseDir.toAbsolutePath());
 
-      if (!allowClusterReuse && Files.exists(baseDir)) {
+      if (!allowClusterReuse && Files.exists(miniClusterBaseDir)) {
         log("mini cluster base directory exists, removing ...");
         try {
-          deleteDirectory(baseDir);
+          deleteDirectory(miniClusterBaseDir);
         } catch (IOException e) {
           throw new RuntimeException(e);
         }
         createCollectionAndIndex = true;
-      } else if (Files.exists(baseDir)) {
+      } else if (Files.exists(miniClusterBaseDir)) {
         createCollectionAndIndex = false;
         deleteMiniCluster = false;

Review comment:
       Is this value ever read?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org