You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2012/04/25 14:45:28 UTC

DO NOT REPLY [Bug 119287] New: Shadow is not applied to chart initially.

https://issues.apache.org/ooo/show_bug.cgi?id=119287

             Bug #: 119287
        Issue Type: DEFECT
           Summary: Shadow is not applied to chart initially.
    Classification: Application
           Product: Drawing
           Version: version58
          Platform: PC
        OS/Version: Windows 7
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ui
        AssignedTo: graphicsneedsconfirm@graphics.openoffice.org
        ReportedBy: qa@imsoftwaresystems.com
                CC: ooo-issues@incubator.apache.org


Created attachment 77493
  --> https://issues.apache.org/ooo/attachment.cgi?id=77493
Shadow not applied to chart.

Select Drawing application => Create a star from "Stars" => Place chart from
the tool bar =>Select star => From context menu, select "Edit Style" => Select
Shadow tab => Select "Use Shadow" => Click on "OK".

Shadow is applied only to star but not chart where as it is expected but If the
chart is selected,line is selected from the context menu and line style is
changed then the shadow is applied to chart.

-- 
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Issue 119287] Shadow is not applied to chart initially.

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119287

--- Comment #11 from SVN Robot <sv...@dev.null.org> ---
"alg" committed SVN revision 1609118 into trunk:
i119287 corrected default style for draw objects created using UNO API

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are watching all issue changes.

DO NOT REPLY [Bug 119287] Shadow is not applied to chart initially.

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119287

--- Comment #2 from Armin Le Grand <Ar...@me.com> 2012-04-25 13:09:56 UTC ---
ALG: Has to do with default formatting: Using format/default_formatting from
the menu will make styles work for chart and graphics. This means that for
these object types initial hard attributes are set.

And yes, there are hard attributes set. This was necessary since in older OOo
versions OLE and graphics were not able to have styles (line, fill, etc.) but
internally used the default fill style. This means all ever created OLE and
graphic are by default filled, but it was never visualized. This is corrected
at load time (old OLE and graphic get fill set hard to none) and at
construction time.

The only way I see to change this would be to have an extra graphics default
style for OLE and graphic objects. I will have to think about the implications
of doing this...

-- 
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 119287] Shadow is not applied to chart initially.

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119287

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ACCEPTED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Armin Le Grand <Ar...@me.com> ---
ALG: Works as expected, including burn in for StyleSheetAttributes when
transfering. Done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 119287] Shadow is not applied to chart initially.

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119287

liupingtan <do...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|VERIFIED                    |CLOSED
                 CC|                            |doneyourself@gmail.com

--- Comment #10 from liupingtan <do...@gmail.com> ---
confirm fixing the bug on ver 1351249 in Win7 ,pass

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 119287] Shadow is not applied to chart initially.

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119287

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #6 from Armin Le Grand <Ar...@me.com> ---
ALG: Reopening, e.g. convert ellipe to bitmap/metafile creates SdrGrafObj, but
with default attributes. This needs to be adapted. All in all constructors for
SdrGrafObj and SdrSdrOle2Obj need to be checked more carefully.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Issue 119287] Shadow is not applied to chart initially.

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119287

--- Comment #13 from SVN Robot <sv...@dev.null.org> ---
"alg" committed SVN revision 1609460 into branches/AOO410:
i119287 corrected default style for draw objects created using UNO API

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are watching all issue changes.

DO NOT REPLY [Bug 119287] Shadow is not applied to chart initially.

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119287

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
                 CC|                            |Armin.Le.Grand@me.com
         AssignedTo|graphicsneedsconfirm@graphi |Armin.Le.Grand@me.com
                   |cs.openoffice.org           |
     Ever Confirmed|0                           |1

--- Comment #1 from Armin Le Grand <Ar...@me.com> 2012-04-25 13:02:28 UTC ---
ALG: Ole objects (chart in this case) seem to have the style not correctly
initialized. When pressing F11 (style and formatting) and vice-versa selecting
star or OLE it displays the style the object has.
When selecting OLE and then double-klicking on Default in the F11 view the OLE
gets the style and all further actions (e.g. changing the style) work as
expected.

I will need to check initial state of style for OLE (and of inserted graphics,
seems to be the same case).

-- 
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 119287] Shadow is not applied to chart initially.

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119287

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |AOO 4.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 119287] Shadow is not applied to chart initially.

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119287

--- Comment #4 from Armin Le Grand <Ar...@me.com> ---
ALG: Removed hard attribute setting at OleProperties::ForceDefaultAttributes
and GraphicProperties::ForceDefaultAttributes to allow a style to 'shine
through' with his fill and line style. To still create valid OLE and graphic
objects I added a new default style NoFillNoLine which these get initially and
which has the style 'Default' as parent. This allows to change e.g. the shadow
of the default style and have all objects (including OLE and GraphicObject) use
it (same with fill and line). The principle is: as less hard attributes as
possible.
Checked save/load cycle, exchange with OOo3.3 and others, works well.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Issue 119287] Shadow is not applied to chart initially.

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119287

--- Comment #12 from Armin Le Grand <Ar...@me.com> ---
Please ignore comment 11, I used the wrong Issue ID in the commit, sorry. Task
for this commit was Issue 125222.

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are watching all issue changes.

[Bug 119287] Shadow is not applied to chart initially.

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119287

louqle <lo...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |VERIFIED
                 CC|                            |louqingle@gmail.com

--- Comment #9 from louqle <lo...@gmail.com> ---
verified in r1350879

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 119287] Shadow is not applied to chart initially.

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119287

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ACCEPTED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Armin Le Grand <Ar...@me.com> ---
ALG: Okay, done. Comitted to trunk with r1344740.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 119287] Shadow is not applied to chart initially.

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119287

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |ACCEPTED

--- Comment #3 from Armin Le Grand <Ar...@me.com> ---
ALG: createNewSdrLineFillShadowTextAttribute (used in primitive creation)
needed to check for shadow not only when there is text or fill or line, but
also when there is content, in the cases of OLE and graphic objects. This was
already implemented as exception for graphic object, but not for OLE. Unified
these approaches and named it more clearly.
Investigating in a possible style 'NoLineNoFill' to avoid setting hard
attributes for line and fill for OLE and graphic objects...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 119287] Shadow is not applied to chart initially.

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119287

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |ACCEPTED

--- Comment #7 from Armin Le Grand <Ar...@me.com> ---
ALG: Need another approach, the StyleSheet needs to be in place at all
Ole/Graphic objects in principle. To do so, it's very sad that aw080 is not
done yet; there the SDrObjects have a SDrModel at creation time and could be
inited there. For the current office I need a compromize. It is good to use
::SetPage(), better as ::SetModel() which would be good but will collide with
aw080 definitely. To not risk to loose this change in aw080, I put it to
SetPage() and make comments for aw080 there (TTTT is my temporary tag for aw080
todos). Building and testing...

-- 
You are receiving this mail because:
You are on the CC list for the bug.