Re: [PR] [CELEBORN-2468] Support pluggable transport authentication and authorization [celeborn]

["gauravkm (via GitHub)" <gi...@apache.org>]

gauravkm commented on PR #3857:
URL: https://github.com/apache/celeborn/pull/3857#issuecomment-5905045796

   CI is still failing: Maven [service (8)](https://github.com/apache/celeborn/actions/runs/36674059346/job/109755070246), [service (11)](https://github.com/apache/celeborn/actions/runs/36674059346/job/109755070240), and [service (17)](https://github.com/apache/celeborn/actions/runs/36674059346/job/109755070969). The Java 11 log shows a ConfigurationSuite golden-file mismatch for `docs/configuration/network.md` (trailing whitespace); I have not established the causes of the other two failures. Other checks are still running.
   
   Looks good from my code review of `ef31bbb`; no P0/P1 issues found. I checked remote versus local dispatch, internal forwarding, native/custom authentication composition, effective quota/ownership identity, replica permissions, stream controls and bootstrap cleanup. The shared dispatch hook applies policy before both request/reply and one-way processing. Added test source covers real RPC denial, worker-loss state preservation, reconnects and replicated shuffle data/ownership. This code-review conclusion does not clear the outstanding CI failures.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org