[jira] [Commented] (OOZIE-1500) Fix many OS-specific issues on Windows

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782360#comment-13782360 ] 

Hadoop QA commented on OOZIE-1500:
----------------------------------

Testing JIRA OOZIE-1500

Cleaning local svn workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:red}-1{color} the patch contains 21 line(s) longer than 132 characters
.    {color:green}+1{color} the patch does adds/modifies 40 testcase(s)
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.    Tests run: 1334
{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/813/

> Fix many OS-specific issues on Windows
> --------------------------------------
>
>                 Key: OOZIE-1500
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1500
>             Project: Oozie
>          Issue Type: Sub-task
>          Components: build, core, examples, scripts, tests
>         Environment: Windows
>            Reporter: David Wannemacher
>            Assignee: David Wannemacher
>             Fix For: trunk
>
>         Attachments: OOZIE-1500.2.patch, OOZIE-1500.patch, OOZIE-1500.trunk.3.patch
>
>
> This is a large patch, please let me know if I should split it up and/or use the code reviewer tool. I tested it on linux and verified that it did not cause any unit test regressions.
> This patch fixes many unix-specific assumptions in code and tests:
> # Using "/" as a path separator. On windows, the right separator is "\". Fix: create a new Path object with the directory and subdirectory names, which handles using the right separator.
> # Determining whether a path is absolute by testing if it begins with "/". Fix: Create a new File object and use isAbsolute().
> # Generating a pathname by concatenating "file://", getTestCaseDir(), File.separator, and the file name. This is wrong because this is a URI, and File.separator is "/" on unix but "\" on windows. Fix: New helper method getTestCaseFileUri solves this.
> # Create directories by using "mkdir" shell command with hard-coded file separators. Fix: Create a new File object and use mkdirs().
> # Scripts that use unix-only commands (ls, echo, etc.). Fix: Implement windows-specific commands and use Shell.WINDOWS to pick the right one at runtime.
> # Assume that perl exists in TestShellActionExecutor.testPerlScript. It doesn't on Windows. Fix: skip the test on Windows.
> # Use the test case name as part of the temp directory name in order to ensure directories are unique. This can cause issues on Windows. Fix: Use a random UUID instead.
> # As a result of using getTestCaseUri, some test case verification that uses string equality fails. (TestLiteWorkflowAppService) Fix: use URI equivalence instead of string equality.
> # AdminServlet tests verify that system variables are working by checking for a USER variable. This is called USERNAME in windows. Fix: On Windows, check for USERNAME instead.
> # TestHostnameFilter checks that "localhost" is in the filter. On Windows, this is "127.0.0.1". Fix: On Windows, check for 127.0.0.1 instead.
> On windows there are still several tests failing. I hope to spend some time fixing these later:
> {noformat}
> Failed tests:
> testActionCheck(org.apache.oozie.command.wf.TestActionCheckXCommand)
> testActionCheckTransientDuringLauncher(org.apache.oozie.command.wf.TestActionCheckXCommand)
> testActionCheckTransientDuringMRAction(org.apache.oozie.command.wf.TestActionCheckXCommand)
> testCoordinatorActionCommands(org.apache.oozie.sla.TestSLAEventGeneration): expected:<NOT_STARTED> but was:<IN_PROCESS>
> testChmodWithGlob(org.apache.oozie.action.hadoop.TestFsActionExecutor): expected:<rw[-]------> but was:<rw[x]------>
> Tests in error:
> testWaitFor(org.apache.oozie.test.TestXTestCase): could not delete path [D:\apache\oozie\core\target\test-data\oozietests\org.apache.oozie.test.TestXTestCase$MyXTestCase\testWaitFor\conf\oozie-site.xml]
> testBaseDir(org.apache.oozie.test.TestXTestCase): could not delete path [D:\apache\oozie\core\target\test-data\oozietests\org.apache.oozie.test.TestXTestCase$MyXTestCase\testBaseDir\conf\oozie-site.xml]
> {noformat}
> How to run unit tests in windows:
> # You will need to build hadoop-core from branch-1-win and install it into your local maven cache. 
> # In the root pom.xml, replace the dummy value in HADOOP_HOME with the path to the hadoop directory. The minicluster tests require bin\winutils.exe to be in this directory.
> # In the root pom.xml (and hadooplibs version 1 pom.xmls, if OOZIE-1490 is not committed yet) change the hadoop version to the version built from branch-1-win.
> # May also need to use Hive 0.11 with the windows fixes.



--
This message was sent by Atlassian JIRA
(v6.1#6144)