You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/04/09 07:44:29 UTC
[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12966
Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test
......................................................................
KUDU-2764: reduce runtime of sentry_authz_provider-test
This patch addresses this by:
1. removing unnecessary parameterization on Kerberos, opting for not
using Kerberos since Kerberos shouldn't affect the
SentryAuthzProvider's behavior, and
2. sharding the test.
Change-Id: I4ebb282cbf0e12c5c0d0d14257711179d88426eb
---
M src/kudu/master/CMakeLists.txt
M src/kudu/master/sentry_authz_provider-test.cc
2 files changed, 18 insertions(+), 46 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/12966/1
--
To view, visit http://gerrit.cloudera.org:8080/12966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ebb282cbf0e12c5c0d0d14257711179d88426eb
Gerrit-Change-Number: 12966
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12966 )
Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test
......................................................................
KUDU-2764: reduce runtime of sentry_authz_provider-test
This patch addresses this by:
1. removing unnecessary parameterization on Kerberos, opting for using
Kerberos, the default behavior; and
2. sharding the test.
Change-Id: I4ebb282cbf0e12c5c0d0d14257711179d88426eb
Reviewed-on: http://gerrit.cloudera.org:8080/12966
Tested-by: Kudu Jenkins
Reviewed-by: Hao Hao <ha...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/master/CMakeLists.txt
M src/kudu/master/sentry_authz_provider-test.cc
2 files changed, 17 insertions(+), 48 deletions(-)
Approvals:
Kudu Jenkins: Verified
Hao Hao: Looks good to me, approved
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4ebb282cbf0e12c5c0d0d14257711179d88426eb
Gerrit-Change-Number: 12966
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12966 )
Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12966/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12966/1//COMMIT_MSG@10
PS1, Line 10: on Kerberos
I will disable the parameterization on non-Kerberos, but keep the Kerberos setting. Because that is the setup for common use case with Sentry. Any reasons you are doing the opposite?
--
To view, visit http://gerrit.cloudera.org:8080/12966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ebb282cbf0e12c5c0d0d14257711179d88426eb
Gerrit-Change-Number: 12966
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 09 Apr 2019 18:56:21 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12966 )
Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12966/1/src/kudu/master/sentry_authz_provider-test.cc
File src/kudu/master/sentry_authz_provider-test.cc:
http://gerrit.cloudera.org:8080/#/c/12966/1/src/kudu/master/sentry_authz_provider-test.cc@172
PS1, Line 172: FLAGS_sentry_service_security_mode = "none";
OK, so these tests are no longer using Kerberized mode at all. Do we have some other tests that cover the Kerberized case for SentryAuthzProvider at all?
--
To view, visit http://gerrit.cloudera.org:8080/12966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ebb282cbf0e12c5c0d0d14257711179d88426eb
Gerrit-Change-Number: 12966
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 09 Apr 2019 17:33:20 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12966 )
Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test
......................................................................
Patch Set 1:
> Patch Set 1:
>
> How important is this change? Do you want to land it immediately? It's been a PITA to integrate all those changes flying around into https://gerrit.cloudera.org/#/c/12833/
Yeah, I don't mind doing this after your patch lands. I made this change per Hao's request here: https://gerrit.cloudera.org/c/12941/4/src/kudu/master/sentry_authz_provider-test.cc#340
--
To view, visit http://gerrit.cloudera.org:8080/12966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ebb282cbf0e12c5c0d0d14257711179d88426eb
Gerrit-Change-Number: 12966
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 09 Apr 2019 17:22:17 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12966
to look at the new patch set (#4).
Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test
......................................................................
KUDU-2764: reduce runtime of sentry_authz_provider-test
This patch addresses this by:
1. removing unnecessary parameterization on Kerberos, opting for using
Kerberos, the default behavior; and
2. sharding the test.
Change-Id: I4ebb282cbf0e12c5c0d0d14257711179d88426eb
---
M src/kudu/master/CMakeLists.txt
M src/kudu/master/sentry_authz_provider-test.cc
2 files changed, 17 insertions(+), 48 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/12966/4
--
To view, visit http://gerrit.cloudera.org:8080/12966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4ebb282cbf0e12c5c0d0d14257711179d88426eb
Gerrit-Change-Number: 12966
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12966 )
Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12966/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12966/1//COMMIT_MSG@10
PS1, Line 10: on Kerberos
> See PS4
Oops, sorry somehow I missed the latest patch.
--
To view, visit http://gerrit.cloudera.org:8080/12966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ebb282cbf0e12c5c0d0d14257711179d88426eb
Gerrit-Change-Number: 12966
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 09 Apr 2019 19:01:53 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12966
to look at the new patch set (#2).
Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test
......................................................................
KUDU-2764: reduce runtime of sentry_authz_provider-test
This patch addresses this by:
1. removing unnecessary parameterization on Kerberos, opting for not
using Kerberos since Kerberos shouldn't affect the
SentryAuthzProvider's behavior (Kerberos is enabeld by default in
integration tests anyway), and
2. sharding the test.
Change-Id: I4ebb282cbf0e12c5c0d0d14257711179d88426eb
---
M src/kudu/master/CMakeLists.txt
M src/kudu/master/sentry_authz_provider-test.cc
2 files changed, 18 insertions(+), 46 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/12966/2
--
To view, visit http://gerrit.cloudera.org:8080/12966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4ebb282cbf0e12c5c0d0d14257711179d88426eb
Gerrit-Change-Number: 12966
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12966 )
Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12966/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12966/1//COMMIT_MSG@11
PS1, Line 11: ; and
: 2. sharding the test.
> Yeah, Sentry itests that use the default settings will use Kerberos.
Ah, that's great. Also, keeping Kerberos on by default looks better since that's the 'standard' way how things are supposed to be glued together.
--
To view, visit http://gerrit.cloudera.org:8080/12966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ebb282cbf0e12c5c0d0d14257711179d88426eb
Gerrit-Change-Number: 12966
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 09 Apr 2019 20:36:05 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12966 )
Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12966/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12966/1//COMMIT_MSG@11
PS1, Line 11: shouldn't affect the
: SentryAuthzProvider's behavior
> It shouldn't, but some funny things might be just overlooked. Do we have s
Yeah, Sentry itests that use the default settings will use Kerberos.
http://gerrit.cloudera.org:8080/#/c/12966/1/src/kudu/master/sentry_authz_provider-test.cc
File src/kudu/master/sentry_authz_provider-test.cc:
http://gerrit.cloudera.org:8080/#/c/12966/1/src/kudu/master/sentry_authz_provider-test.cc@172
PS1, Line 172: FLAGS_sentry_service_security_mode = "none";
> OK, so these tests are no longer using Kerberized mode at all. Do we have
Yeah, noted in the commit message.
--
To view, visit http://gerrit.cloudera.org:8080/12966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ebb282cbf0e12c5c0d0d14257711179d88426eb
Gerrit-Change-Number: 12966
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 09 Apr 2019 18:04:44 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12966 )
Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test
......................................................................
Patch Set 1:
How important is this change? Do you want to land it immediately? It's been a PITA to integrate all those changes flying around into https://gerrit.cloudera.org/#/c/12833/
--
To view, visit http://gerrit.cloudera.org:8080/12966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ebb282cbf0e12c5c0d0d14257711179d88426eb
Gerrit-Change-Number: 12966
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 09 Apr 2019 17:20:51 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12966 )
Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test
......................................................................
Patch Set 1: Code-Review+1
> > Patch Set 1:
> >
> > How important is this change? Do you want to land it
> immediately? It's been a PITA to integrate all those changes
> flying around into https://gerrit.cloudera.org/#/c/12833/
>
> Yeah, I don't mind doing this after your patch lands. I made this
> change per Hao's request here: https://gerrit.cloudera.org/c/12941/4/src/kudu/master/sentry_authz_provider-test.cc#340
All right, if that's about stability of the tests and failing pre-commit checks and etc., I think we can benefit from pushing this one as soon as possible. I'll re-base on top of these changes then, no problem.
--
To view, visit http://gerrit.cloudera.org:8080/12966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ebb282cbf0e12c5c0d0d14257711179d88426eb
Gerrit-Change-Number: 12966
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 09 Apr 2019 17:27:09 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12966 )
Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12966/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12966/1//COMMIT_MSG@10
PS1, Line 10: on Kerberos
> I will disable the parameterization on non-Kerberos, but keep the Kerberos
See PS4
--
To view, visit http://gerrit.cloudera.org:8080/12966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ebb282cbf0e12c5c0d0d14257711179d88426eb
Gerrit-Change-Number: 12966
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 09 Apr 2019 18:57:38 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12966
to look at the new patch set (#3).
Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test
......................................................................
KUDU-2764: reduce runtime of sentry_authz_provider-test
This patch addresses this by:
1. removing unnecessary parameterization on Kerberos, opting for not
using Kerberos since Kerberos shouldn't affect the
SentryAuthzProvider's behavior (Kerberos is enabled by default in
integration tests anyway), and
2. sharding the test.
Change-Id: I4ebb282cbf0e12c5c0d0d14257711179d88426eb
---
M src/kudu/master/CMakeLists.txt
M src/kudu/master/sentry_authz_provider-test.cc
2 files changed, 18 insertions(+), 46 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/12966/3
--
To view, visit http://gerrit.cloudera.org:8080/12966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4ebb282cbf0e12c5c0d0d14257711179d88426eb
Gerrit-Change-Number: 12966
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12966 )
Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test
......................................................................
Patch Set 3:
> Patch Set 3:
>
> (2 comments)
Actually after considering it more, I've had a change of heart, see:
https://gerrit.cloudera.org/c/12833/9/src/kudu/master/sentry_authz_provider-test.cc#428
--
To view, visit http://gerrit.cloudera.org:8080/12966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ebb282cbf0e12c5c0d0d14257711179d88426eb
Gerrit-Change-Number: 12966
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 09 Apr 2019 18:12:39 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12966 )
Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12966/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12966/1//COMMIT_MSG@11
PS1, Line 11: shouldn't affect the
: SentryAuthzProvider's behavior
It shouldn't, but some funny things might be just overlooked. Do we have some other to cover that functionality at all? If yes, maybe add the reference to that test in this commit message for posterity?
--
To view, visit http://gerrit.cloudera.org:8080/12966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ebb282cbf0e12c5c0d0d14257711179d88426eb
Gerrit-Change-Number: 12966
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 09 Apr 2019 17:38:18 +0000
Gerrit-HasComments: Yes