[myfaces-tobago] 01/02: TOBAGO-1862: Paging links in Sheet should not use href="#/"

[lo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

lofwyr pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git

commit f081d3508ec9577fd1a2682a565e5c1b1229b7f8
Author: Udo Schnurpfeil <lo...@apache.org>
AuthorDate: Fri Mar 2 11:42:36 2018 +0100

    TOBAGO-1862: Paging links in Sheet should not use href="#/"
    
    using <button> instead of <a>
---
 .../myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java
index 8a9afd3..6a5572d 100644
--- a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java
+++ b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java
@@ -63,6 +63,7 @@ import org.apache.myfaces.tobago.renderkit.css.Icons;
 import org.apache.myfaces.tobago.renderkit.css.TobagoClass;
 import org.apache.myfaces.tobago.renderkit.html.DataAttributes;
 import org.apache.myfaces.tobago.renderkit.html.HtmlAttributes;
+import org.apache.myfaces.tobago.renderkit.html.HtmlButtonTypes;
 import org.apache.myfaces.tobago.renderkit.html.HtmlElements;
 import org.apache.myfaces.tobago.renderkit.html.HtmlInputTypes;
 import org.apache.myfaces.tobago.util.ComponentUtils;
@@ -1078,10 +1079,9 @@ public class SheetRenderer extends RendererBase {
     final TobagoResponseWriter writer = getResponseWriter(facesContext);
     writer.startElement(HtmlElements.LI);
     writer.writeClassAttribute(liClass, disabled ? BootstrapClass.DISABLED : null, BootstrapClass.PAGE_ITEM);
-// todo button
-    writer.startElement(HtmlElements.A);
+    writer.startElement(HtmlElements.BUTTON);
+    writer.writeAttribute(HtmlAttributes.TYPE, HtmlButtonTypes.BUTTON);
     writer.writeClassAttribute(BootstrapClass.PAGE_LINK);
-    writer.writeAttribute(HtmlAttributes.HREF, "#/", false);
     writer.writeIdAttribute(command.getClientId(facesContext));
     writer.writeAttribute(HtmlAttributes.TITLE, tip, true);
     if (!disabled) {
@@ -1096,7 +1096,7 @@ public class SheetRenderer extends RendererBase {
       writer.writeText(String.valueOf(target));
     }
     data.getFacets().remove(facet);
-    writer.endElement(HtmlElements.A);
+    writer.endElement(HtmlElements.BUTTON);
     writer.endElement(HtmlElements.LI);
   }
 

-- 
To stop receiving notification emails like this one, please contact
lofwyr@apache.org.