[commons-collections] 02/03: Test code cleanup

[ah...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-collections.git

commit bf836c8df0648eda397e0df8114e35b2e7bc8938
Author: aherbert <a....@sussex.ac.uk>
AuthorDate: Tue Aug 23 11:30:17 2022 +0100

    Test code cleanup
    
    Use static
    
    Remove incorrect javadoc tags
    
    Add javadoc to return tag
---
 .../collections4/bloomfilter/AbstractBitCountProducerTest.java      | 2 +-
 .../commons/collections4/bloomfilter/AbstractBloomFilterTest.java   | 6 +-----
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/test/java/org/apache/commons/collections4/bloomfilter/AbstractBitCountProducerTest.java b/src/test/java/org/apache/commons/collections4/bloomfilter/AbstractBitCountProducerTest.java
index 5894b7c37..e51f90105 100644
--- a/src/test/java/org/apache/commons/collections4/bloomfilter/AbstractBitCountProducerTest.java
+++ b/src/test/java/org/apache/commons/collections4/bloomfilter/AbstractBitCountProducerTest.java
@@ -63,7 +63,7 @@ public abstract class AbstractBitCountProducerTest extends AbstractIndexProducer
     /**
      * Determines if empty tests should be run.  Some producers do not implement an empty
      * version.  Tests for those classes should return false.
-     * @return
+     * @return true if the empty tests are supported
      */
     protected boolean supportsEmpty() {
         return true;
diff --git a/src/test/java/org/apache/commons/collections4/bloomfilter/AbstractBloomFilterTest.java b/src/test/java/org/apache/commons/collections4/bloomfilter/AbstractBloomFilterTest.java
index a61885491..da2aa897c 100644
--- a/src/test/java/org/apache/commons/collections4/bloomfilter/AbstractBloomFilterTest.java
+++ b/src/test/java/org/apache/commons/collections4/bloomfilter/AbstractBloomFilterTest.java
@@ -189,8 +189,6 @@ public abstract class AbstractBloomFilterTest<T extends BloomFilter> {
 
     /**
      * Tests that the andCardinality calculations are correct.
-     *
-     * @param filterFactory the factory function to create the filter
      */
     @Test
     public final void testEstimateIntersection() {
@@ -209,8 +207,6 @@ public abstract class AbstractBloomFilterTest<T extends BloomFilter> {
 
     /**
      * Tests that the andCardinality calculations are correct.
-     *
-     * @param filterFactory the factory function to create the filter
      */
     @Test
     public final void testEstimateUnion() {
@@ -331,7 +327,7 @@ public abstract class AbstractBloomFilterTest<T extends BloomFilter> {
         assertThrows(IllegalArgumentException.class, () -> bf1.merge(bf6));
     }
 
-    private void assertIndexProducerConstructor(Shape shape, int[] values, int[] expected) {
+    private static void assertIndexProducerConstructor(Shape shape, int[] values, int[] expected) {
         IndexProducer indices = IndexProducer.fromIndexArray(values);
         SparseBloomFilter filter = new SparseBloomFilter(shape, indices);
         List<Integer> lst = new ArrayList<>();