You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "jbertram (via GitHub)" <gi...@apache.org> on 2024/08/26 19:55:48 UTC
[PR] ARTEMIS-5012 update docs & code to clarify resource-limit-settings [activemq-artemis]
jbertram opened a new pull request, #5175:
URL: https://github.com/apache/activemq-artemis/pull/5175
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-5012 update docs & code to clarify resource-limit-settings [activemq-artemis]
Posted by "tabish121 (via GitHub)" <gi...@apache.org>.
tabish121 commented on code in PR #5175:
URL: https://github.com/apache/activemq-artemis/pull/5175#discussion_r1731751791
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/ResourceLimitSettings.java:
##########
@@ -79,7 +84,12 @@ public void setMatch(SimpleString match) {
}
public void setMaxConnections(int maxConnections) {
- this.maxConnections = maxConnections;
+ this.maxSessions = maxConnections;
+ }
+
+ @Deprecated(forRemoval = true)
+ public void setMaxSessions(int maxConnections) {
Review Comment:
should setMaxSessions not take a param named maxSessions ?
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/ResourceLimitSettings.java:
##########
@@ -79,7 +84,12 @@ public void setMatch(SimpleString match) {
}
public void setMaxConnections(int maxConnections) {
- this.maxConnections = maxConnections;
+ this.maxSessions = maxConnections;
+ }
+
+ @Deprecated(forRemoval = true)
Review Comment:
I'm guessing you meant to depreate setMaxConnections and not the setMaxSessions API you've just created ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-5012 update docs & code to clarify resource-limit-settings [activemq-artemis]
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on code in PR #5175:
URL: https://github.com/apache/activemq-artemis/pull/5175#discussion_r1731756230
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/ResourceLimitSettings.java:
##########
@@ -79,7 +84,12 @@ public void setMatch(SimpleString match) {
}
public void setMaxConnections(int maxConnections) {
- this.maxConnections = maxConnections;
+ this.maxSessions = maxConnections;
+ }
+
+ @Deprecated(forRemoval = true)
Review Comment:
Indeed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-5012 update docs & code to clarify resource-limit-settings [activemq-artemis]
Posted by "tabish121 (via GitHub)" <gi...@apache.org>.
tabish121 merged PR #5175:
URL: https://github.com/apache/activemq-artemis/pull/5175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact