[GitHub] [openwhisk-runtime-php] rabbah commented on a change in pull request #113: Upgrade gradle and use mavenCentral because jCentral does not exist a…

[GitBox <gi...@apache.org>]

rabbah commented on a change in pull request #113:
URL: https://github.com/apache/openwhisk-runtime-php/pull/113#discussion_r788221672



##########
File path: build.gradle
##########
@@ -14,17 +14,28 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+plugins {
+    id 'scala'
+    id 'java'
+    id 'idea'
+    id 'eclipse'
+    id 'cz.alenkacz.gradle.scalafmt' version "${scalamftVersion}"
+}
 
-buildscript {
+subprojects {
+    gradle.ext.scalafmt.configFilePath = gradle.ext.scalafmt.config
+}
+allprojects {

Review comment:
       ```suggestion
   
   allprojects {
   ```

##########
File path: tools/travis/test.sh
##########
@@ -26,5 +26,4 @@ WHISKDIR="$ROOTDIR/../openwhisk"
 
 export OPENWHISK_HOME=$WHISKDIR
 cd ${ROOTDIR}
-TERM=dumb ./gradlew :tests:checkScalafmtAll

Review comment:
       Why did you drop this? Does scalafmt run automatically now?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org