[GitHub] [pulsar] RobertIndie commented on pull request #16703: [fix][test] Fix testEntryFilterRescheduleMessageDependingOnConsumerSharedSubscription

[GitBox <gi...@apache.org>]

RobertIndie commented on PR #16703:
URL: https://github.com/apache/pulsar/pull/16703#issuecomment-1192110517

   > initially I set the size to 5 because the test may take to long, because we had a fixed delay of 1000 in case of RESCHEDULE
   > 
   > now it is configurable with `dispatcherEntryFilterRescheduledMessageDelay`, reducing it to 100ms may probably help to make the test run faster
   
   Thanks. That's another approach. But I think the current approach s enough to reduce the time spent on testing.
   
   
   
   > 1. The message will be redelivered multiple times, which can also make this test to be flaky
   
   This PR greatly reduces the number of messages re-deliveries. And there is a 1-minute wait time, which I think is enough.
   
   > 2. Is `Key_Shared` subscription supported for this feature? AFAICS, `Key_Shared` consumer may introduce endless redeliver
   
   That's another topic. I will take a look later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org