You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by Jens-G <gi...@git.apache.org> on 2016/03/25 00:39:04 UTC

[GitHub] thrift pull request: THRIFT-3751 Compiler allows field ids that ar...

GitHub user Jens-G opened a pull request:

    https://github.com/apache/thrift/pull/964

    THRIFT-3751 Compiler allows field ids that are too large for generate…

    …d code
    
    Client: Compiler (General)
    Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Jens-G/thrift THRIFT-3751

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/964.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #964
    
----
commit 157017c352ff713c866778b254df6c6aa00f282f
Author: Jens Geyer <je...@apache.org>
Date:   2016-03-24T23:34:03Z

    THRIFT-3751 Compiler allows field ids that are too large for generated code
    Client: Compiler (General)
    Patch: Jens Geyer

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3751 Compiler allows field ids that ar...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/964


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3751 Compiler allows field ids that ar...

Posted by nsuke <gi...@git.apache.org>.
Github user nsuke commented on the pull request:

    https://github.com/apache/thrift/pull/964#issuecomment-201082596
  
    +1
    
    npm fails too often...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---