[GitHub] [solr] risdenk commented on a diff in pull request #1445: SOLR-16692: Use HttpCookieStore.Empty in Http2SolrClient

["risdenk (via GitHub)" <gi...@apache.org>]

risdenk commented on code in PR #1445:
URL: https://github.com/apache/solr/pull/1445#discussion_r1132433853


##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -266,6 +267,7 @@ private HttpClient createHttpClient(Builder builder) {
         asyncTracker.getMaxRequestsQueuedPerDestination());
     httpClient.setUserAgentField(new HttpField(HttpHeader.USER_AGENT, AGENT));
     httpClient.setIdleTimeout(idleTimeoutMillis);
+    httpClient.setCookieStore(new HttpCookieStore.Empty());

Review Comment:
   So another big consideration here besides authentication - is load balancers also use cookies to ensure there client goes back to the same backend endpoint. 



##########
solr/benchmark/src/java/org/apache/solr/bench/MiniClusterState.java:
##########
@@ -273,7 +273,7 @@ public void startMiniCluster(int nodeCount) {
         nodes.add(runner.getBaseUrl().toString());
       }
 
-      client = new Http2SolrClient.Builder().build();
+      client = new Http2SolrClient.Builder().useHttp1_1(true).build();

Review Comment:
   any details on "break" means here? what did you run specifically to run the benchmark? I'll see if I can reproduce.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org