You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/12/12 01:48:08 UTC
[GitHub] [hive] jcamachor opened a new pull request #1769: HIVE-24527: Allow triggering materialized view rewriting for external tables
jcamachor opened a new pull request #1769:
URL: https://github.com/apache/hive/pull/1769
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] jcamachor closed pull request #1769: HIVE-24527: Allow triggering materialized view rewriting for external tables
Posted by GitBox <gi...@apache.org>.
jcamachor closed pull request #1769:
URL: https://github.com/apache/hive/pull/1769
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kasakrisz commented on a change in pull request #1769: HIVE-24527: Allow triggering materialized view rewriting for external tables
Posted by GitBox <gi...@apache.org>.
kasakrisz commented on a change in pull request #1769:
URL: https://github.com/apache/hive/pull/1769#discussion_r542123745
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
##########
@@ -13928,13 +13929,16 @@ private void validateCreateView()
throw new SemanticException("View definition references materialized view " + alias);
}
if (createVwDesc.isRewriteEnabled() && !AcidUtils.isTransactionalTable(table)) {
- throw new SemanticException("Automatic rewriting for materialized view cannot "
- + "be enabled if the materialized view uses non-transactional tables");
+ usesNonTransactional = true;
}
} catch (HiveException ex) {
throw new SemanticException(ex);
}
}
+ if (usesNonTransactional) {
+ LOG.warn("Automatic rewriting for materialized view cannot "
Review comment:
Should this be written into the Console too to notify the user about this behavior?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org