You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/14 14:29:43 UTC
[GitHub] [flink] fapaul opened a new pull request #19084: [FLINK-26633][elasticsearch] Add recordSend metric to elasticsearch sink
fapaul opened a new pull request #19084:
URL: https://github.com/apache/flink/pull/19084
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Add recordSend metric to elasticsearch sink
## Brief change log
Increment the recordsSend counter for every request that is generated by the user from a single record.
## Verifying this change
Added a test to verify the counter increases
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on a change in pull request #19084: [FLINK-26633][elasticsearch] Add recordSend metric to elasticsearch sink
Posted by GitBox <gi...@apache.org>.
JingGe commented on a change in pull request #19084:
URL: https://github.com/apache/flink/pull/19084#discussion_r829187419
##########
File path: flink-connectors/flink-connector-elasticsearch-base/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchWriterITCase.java
##########
@@ -239,9 +271,9 @@ void testCurrentSendTime() throws Exception {
boolean flushOnCheckpoint,
BulkProcessorConfig bulkProcessorConfig,
SinkWriterMetricGroup metricGroup) {
- return new ElasticsearchWriter<Tuple2<Integer, String>>(
+ return new ElasticsearchWriter<>(
Collections.singletonList(HttpHost.create(ES_CONTAINER.getHttpHostAddress())),
- TestEmitter.jsonEmitter(index, context.getDataFieldName()),
+ new UpdatingEmitter(index, context.getDataFieldName()),
Review comment:
Excellent idea to perform the test cases!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19084: [FLINK-26633][elasticsearch] Add recordSend metric to elasticsearch sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19084:
URL: https://github.com/apache/flink/pull/19084#issuecomment-1067024206
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "343d4ab4e5037631c99e0214ce27bef621550a19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33035",
"triggerID" : "343d4ab4e5037631c99e0214ce27bef621550a19",
"triggerType" : "PUSH"
}, {
"hash" : "0bba7e0ebc15f5b8cad10634d00dede2f1d4056e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33233",
"triggerID" : "0bba7e0ebc15f5b8cad10634d00dede2f1d4056e",
"triggerType" : "PUSH"
}, {
"hash" : "0bba7e0ebc15f5b8cad10634d00dede2f1d4056e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33233",
"triggerID" : "1072125261",
"triggerType" : "MANUAL"
}, {
"hash" : "7948775359586a16fa983cca6fcfaf3effc5c48b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33358",
"triggerID" : "7948775359586a16fa983cca6fcfaf3effc5c48b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7948775359586a16fa983cca6fcfaf3effc5c48b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33358)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19084: [FLINK-26633][elasticsearch] Add recordSend metric to elasticsearch sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19084:
URL: https://github.com/apache/flink/pull/19084#issuecomment-1067024206
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "343d4ab4e5037631c99e0214ce27bef621550a19",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33035",
"triggerID" : "343d4ab4e5037631c99e0214ce27bef621550a19",
"triggerType" : "PUSH"
}, {
"hash" : "0bba7e0ebc15f5b8cad10634d00dede2f1d4056e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33233",
"triggerID" : "0bba7e0ebc15f5b8cad10634d00dede2f1d4056e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 343d4ab4e5037631c99e0214ce27bef621550a19 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33035)
* 0bba7e0ebc15f5b8cad10634d00dede2f1d4056e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33233)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19084: [FLINK-26633][elasticsearch] Add recordSend metric to elasticsearch sink
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19084:
URL: https://github.com/apache/flink/pull/19084#issuecomment-1067024206
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "343d4ab4e5037631c99e0214ce27bef621550a19",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "343d4ab4e5037631c99e0214ce27bef621550a19",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 343d4ab4e5037631c99e0214ce27bef621550a19 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19084: [FLINK-26633][elasticsearch] Add recordSend metric to elasticsearch sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19084:
URL: https://github.com/apache/flink/pull/19084#issuecomment-1067024206
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "343d4ab4e5037631c99e0214ce27bef621550a19",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33035",
"triggerID" : "343d4ab4e5037631c99e0214ce27bef621550a19",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 343d4ab4e5037631c99e0214ce27bef621550a19 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33035)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on pull request #19084: [FLINK-26633][elasticsearch] Add recordSend metric to elasticsearch sink
Posted by GitBox <gi...@apache.org>.
fapaul commented on pull request #19084:
URL: https://github.com/apache/flink/pull/19084#issuecomment-1072125261
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19084: [FLINK-26633][elasticsearch] Add recordSend metric to elasticsearch sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19084:
URL: https://github.com/apache/flink/pull/19084#issuecomment-1067024206
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "343d4ab4e5037631c99e0214ce27bef621550a19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33035",
"triggerID" : "343d4ab4e5037631c99e0214ce27bef621550a19",
"triggerType" : "PUSH"
}, {
"hash" : "0bba7e0ebc15f5b8cad10634d00dede2f1d4056e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33233",
"triggerID" : "0bba7e0ebc15f5b8cad10634d00dede2f1d4056e",
"triggerType" : "PUSH"
}, {
"hash" : "0bba7e0ebc15f5b8cad10634d00dede2f1d4056e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33233",
"triggerID" : "1072125261",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0bba7e0ebc15f5b8cad10634d00dede2f1d4056e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33233)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19084: [FLINK-26633][elasticsearch] Add recordSend metric to elasticsearch sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19084:
URL: https://github.com/apache/flink/pull/19084#issuecomment-1067024206
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "343d4ab4e5037631c99e0214ce27bef621550a19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33035",
"triggerID" : "343d4ab4e5037631c99e0214ce27bef621550a19",
"triggerType" : "PUSH"
}, {
"hash" : "0bba7e0ebc15f5b8cad10634d00dede2f1d4056e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33233",
"triggerID" : "0bba7e0ebc15f5b8cad10634d00dede2f1d4056e",
"triggerType" : "PUSH"
}, {
"hash" : "0bba7e0ebc15f5b8cad10634d00dede2f1d4056e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33233",
"triggerID" : "1072125261",
"triggerType" : "MANUAL"
}, {
"hash" : "7948775359586a16fa983cca6fcfaf3effc5c48b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33358",
"triggerID" : "7948775359586a16fa983cca6fcfaf3effc5c48b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0bba7e0ebc15f5b8cad10634d00dede2f1d4056e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33233)
* 7948775359586a16fa983cca6fcfaf3effc5c48b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33358)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a change in pull request #19084: [FLINK-26633][elasticsearch] Add recordSend metric to elasticsearch sink
Posted by GitBox <gi...@apache.org>.
fapaul commented on a change in pull request #19084:
URL: https://github.com/apache/flink/pull/19084#discussion_r828992478
##########
File path: flink-connectors/flink-connector-elasticsearch-base/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchWriterITCase.java
##########
@@ -204,6 +205,28 @@ void testIncrementByteOutMetric() throws Exception {
}
}
+ @Test
+ void testIncrementRecordsSendMetric() throws Exception {
+ final String index = "test-inc-records-send";
+ final int flushAfterNActions = 2;
+ final BulkProcessorConfig bulkProcessorConfig =
+ new BulkProcessorConfig(flushAfterNActions, -1, -1, FlushBackoffType.NONE, 0, 0);
+
+ try (final ElasticsearchWriter<Tuple2<Integer, String>> writer =
+ createWriter(index, false, bulkProcessorConfig)) {
+ final Optional<Counter> recordsSend =
+ metricListener.getCounter(MetricNames.NUM_RECORDS_SEND);
+ writer.write(Tuple2.of(1, buildMessage(1)), null);
+ writer.write(Tuple2.of(2, buildMessage(2)), null);
+ writer.write(Tuple2.of(2, buildMessage(3)), null);
Review comment:
I updated the test to send also an update and delete request. Please take another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19084: [FLINK-26633][elasticsearch] Add recordSend metric to elasticsearch sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19084:
URL: https://github.com/apache/flink/pull/19084#issuecomment-1067024206
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "343d4ab4e5037631c99e0214ce27bef621550a19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33035",
"triggerID" : "343d4ab4e5037631c99e0214ce27bef621550a19",
"triggerType" : "PUSH"
}, {
"hash" : "0bba7e0ebc15f5b8cad10634d00dede2f1d4056e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33233",
"triggerID" : "0bba7e0ebc15f5b8cad10634d00dede2f1d4056e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0bba7e0ebc15f5b8cad10634d00dede2f1d4056e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33233)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19084: [FLINK-26633][elasticsearch] Add recordSend metric to elasticsearch sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19084:
URL: https://github.com/apache/flink/pull/19084#issuecomment-1067024206
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "343d4ab4e5037631c99e0214ce27bef621550a19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33035",
"triggerID" : "343d4ab4e5037631c99e0214ce27bef621550a19",
"triggerType" : "PUSH"
}, {
"hash" : "0bba7e0ebc15f5b8cad10634d00dede2f1d4056e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33233",
"triggerID" : "0bba7e0ebc15f5b8cad10634d00dede2f1d4056e",
"triggerType" : "PUSH"
}, {
"hash" : "0bba7e0ebc15f5b8cad10634d00dede2f1d4056e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33233",
"triggerID" : "1072125261",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0bba7e0ebc15f5b8cad10634d00dede2f1d4056e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33233)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19084: [FLINK-26633][elasticsearch] Add recordSend metric to elasticsearch sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19084:
URL: https://github.com/apache/flink/pull/19084#issuecomment-1067024206
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "343d4ab4e5037631c99e0214ce27bef621550a19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33035",
"triggerID" : "343d4ab4e5037631c99e0214ce27bef621550a19",
"triggerType" : "PUSH"
}, {
"hash" : "0bba7e0ebc15f5b8cad10634d00dede2f1d4056e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33233",
"triggerID" : "0bba7e0ebc15f5b8cad10634d00dede2f1d4056e",
"triggerType" : "PUSH"
}, {
"hash" : "0bba7e0ebc15f5b8cad10634d00dede2f1d4056e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33233",
"triggerID" : "1072125261",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0bba7e0ebc15f5b8cad10634d00dede2f1d4056e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33233)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul merged pull request #19084: [FLINK-26633][elasticsearch] Add recordSend metric to elasticsearch sink
Posted by GitBox <gi...@apache.org>.
fapaul merged pull request #19084:
URL: https://github.com/apache/flink/pull/19084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on a change in pull request #19084: [FLINK-26633][elasticsearch] Add recordSend metric to elasticsearch sink
Posted by GitBox <gi...@apache.org>.
JingGe commented on a change in pull request #19084:
URL: https://github.com/apache/flink/pull/19084#discussion_r829187419
##########
File path: flink-connectors/flink-connector-elasticsearch-base/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchWriterITCase.java
##########
@@ -239,9 +271,9 @@ void testCurrentSendTime() throws Exception {
boolean flushOnCheckpoint,
BulkProcessorConfig bulkProcessorConfig,
SinkWriterMetricGroup metricGroup) {
- return new ElasticsearchWriter<Tuple2<Integer, String>>(
+ return new ElasticsearchWriter<>(
Collections.singletonList(HttpHost.create(ES_CONTAINER.getHttpHostAddress())),
- TestEmitter.jsonEmitter(index, context.getDataFieldName()),
+ new UpdatingEmitter(index, context.getDataFieldName()),
Review comment:
Excellent idea to perform the test cases!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on a change in pull request #19084: [FLINK-26633][elasticsearch] Add recordSend metric to elasticsearch sink
Posted by GitBox <gi...@apache.org>.
JingGe commented on a change in pull request #19084:
URL: https://github.com/apache/flink/pull/19084#discussion_r827838830
##########
File path: flink-connectors/flink-connector-elasticsearch-base/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchWriterITCase.java
##########
@@ -204,6 +205,28 @@ void testIncrementByteOutMetric() throws Exception {
}
}
+ @Test
+ void testIncrementRecordsSendMetric() throws Exception {
+ final String index = "test-inc-records-send";
+ final int flushAfterNActions = 2;
+ final BulkProcessorConfig bulkProcessorConfig =
+ new BulkProcessorConfig(flushAfterNActions, -1, -1, FlushBackoffType.NONE, 0, 0);
+
+ try (final ElasticsearchWriter<Tuple2<Integer, String>> writer =
+ createWriter(index, false, bulkProcessorConfig)) {
+ final Optional<Counter> recordsSend =
+ metricListener.getCounter(MetricNames.NUM_RECORDS_SEND);
+ writer.write(Tuple2.of(1, buildMessage(1)), null);
+ writer.write(Tuple2.of(2, buildMessage(2)), null);
+ writer.write(Tuple2.of(2, buildMessage(3)), null);
Review comment:
Could these three write calls test the three add(...) methods, i.e. DeleteRequest, IndexRequest, UpdateRequest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19084: [FLINK-26633][elasticsearch] Add recordSend metric to elasticsearch sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19084:
URL: https://github.com/apache/flink/pull/19084#issuecomment-1067024206
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "343d4ab4e5037631c99e0214ce27bef621550a19",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33035",
"triggerID" : "343d4ab4e5037631c99e0214ce27bef621550a19",
"triggerType" : "PUSH"
}, {
"hash" : "0bba7e0ebc15f5b8cad10634d00dede2f1d4056e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0bba7e0ebc15f5b8cad10634d00dede2f1d4056e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 343d4ab4e5037631c99e0214ce27bef621550a19 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33035)
* 0bba7e0ebc15f5b8cad10634d00dede2f1d4056e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19084: [FLINK-26633][elasticsearch] Add recordSend metric to elasticsearch sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19084:
URL: https://github.com/apache/flink/pull/19084#issuecomment-1067024206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19084: [FLINK-26633][elasticsearch] Add recordSend metric to elasticsearch sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19084:
URL: https://github.com/apache/flink/pull/19084#issuecomment-1067024206
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "343d4ab4e5037631c99e0214ce27bef621550a19",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33035",
"triggerID" : "343d4ab4e5037631c99e0214ce27bef621550a19",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 343d4ab4e5037631c99e0214ce27bef621550a19 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33035)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19084: [FLINK-26633][elasticsearch] Add recordSend metric to elasticsearch sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19084:
URL: https://github.com/apache/flink/pull/19084#issuecomment-1067024206
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "343d4ab4e5037631c99e0214ce27bef621550a19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33035",
"triggerID" : "343d4ab4e5037631c99e0214ce27bef621550a19",
"triggerType" : "PUSH"
}, {
"hash" : "0bba7e0ebc15f5b8cad10634d00dede2f1d4056e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33233",
"triggerID" : "0bba7e0ebc15f5b8cad10634d00dede2f1d4056e",
"triggerType" : "PUSH"
}, {
"hash" : "0bba7e0ebc15f5b8cad10634d00dede2f1d4056e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33233",
"triggerID" : "1072125261",
"triggerType" : "MANUAL"
}, {
"hash" : "7948775359586a16fa983cca6fcfaf3effc5c48b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7948775359586a16fa983cca6fcfaf3effc5c48b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0bba7e0ebc15f5b8cad10634d00dede2f1d4056e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33233)
* 7948775359586a16fa983cca6fcfaf3effc5c48b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on pull request #19084: [FLINK-26633][elasticsearch] Add recordSend metric to elasticsearch sink
Posted by GitBox <gi...@apache.org>.
fapaul commented on pull request #19084:
URL: https://github.com/apache/flink/pull/19084#issuecomment-1072125261
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org