[jira] [Work logged] (BEAM-11648) Implement new BigQuery sink (Vortex)

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-11648?focusedWorklogId=599387&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-599387 ]

ASF GitHub Bot logged work on BEAM-11648:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/May/21 18:17
            Start Date: 19/May/21 18:17
    Worklog Time Spent: 10m 
      Work Description: TheNeuralBit commented on a change in pull request #14309:
URL: https://github.com/apache/beam/pull/14309#discussion_r635479744



##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java
##########
@@ -490,6 +518,7 @@ public Job getJob(JobReference jobRef, Sleeper sleeper, BackOff backoff)
     private DatasetServiceImpl(BigQueryOptions bqOptions) {
       this.errorExtractor = new ApiErrorExtractor();
       this.client = newBigQueryClient(bqOptions).build();
+      this.newWriteClient = newBigQueryWriteClient(bqOptions);

Review comment:
       We're supposed to manage the lifecycle of this client and close it when done. Since this code doesn't do that users see `SEVERE` errors (e.g. BEAM-12359) whenever they use BigQueryIO. I filed BEAM-12365 for this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 599387)
    Time Spent: 48h 50m  (was: 48h 40m)

> Implement new BigQuery sink (Vortex)
> ------------------------------------
>
>                 Key: BEAM-11648
>                 URL: https://issues.apache.org/jira/browse/BEAM-11648
>             Project: Beam
>          Issue Type: New Feature
>          Components: extensions-java-gcp
>            Reporter: Reuven Lax
>            Assignee: Reuven Lax
>            Priority: P2
>              Labels: stale-assigned
>          Time Spent: 48h 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)