You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "kevinjqliu (via GitHub)" <gi...@apache.org> on 2025/07/30 16:33:43 UTC
[I] [epic] add all features of the IRC spec to the IRC reference implementation [iceberg]
kevinjqliu opened a new issue, #13707:
URL: https://github.com/apache/iceberg/issues/13707
### Feature Request / Improvement
If its in the spec (https://iceberg.apache.org/rest-catalog-spec/), it should be in the reference implementation.
I opened https://github.com/apache/iceberg/issues/13706 to track the "scan planning" feature.
The new "Events" endpoint is tracked https://github.com/apache/iceberg/issues/13580
I'll go through the IRC spec and list out all of the missing features so that we can track here
### Query engine
None
### Willingness to contribute
- [ ] I can contribute this improvement/feature independently
- [ ] I would be willing to contribute this improvement/feature with guidance from the Iceberg community
- [ ] I cannot contribute this improvement/feature at this time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [epic] add all features of the IRC spec to the IRC reference implementation [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on issue #13707:
URL: https://github.com/apache/iceberg/issues/13707#issuecomment-3636527792
I don't think we need a reference impl for `Load Table Credentials` in the adapter or in `CatalogHandlers`. The only place where this endpoint is relevant is actually in the storage-related credential provider implementations, such as `OAuth2RefreshCredentialsHandler` / `VendedCredentialsProvider` / `VendedAdlsCredentialProvider`. The REST catalog itself never calls this endpoint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [epic] add all features of the IRC spec to the IRC reference implementation [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on issue #13707:
URL: https://github.com/apache/iceberg/issues/13707#issuecomment-3138218140
Thats a good point. I only looked at the missing endpoints.
ETag / "freshness-aware table loading" was added to the IRC spec in #11946 but I dont think its implemented https://grep.app/search?f.repo=apache%2Ficeberg&f.repo.pattern=iceberg&words=true&q=etag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [epic] add all features of the IRC spec to the IRC reference implementation [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on issue #13707:
URL: https://github.com/apache/iceberg/issues/13707#issuecomment-3144865240
thanks for the context @gaborkaszab I've added it under a new "missing features" section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [epic] add all features of the IRC spec to the IRC reference implementation [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #13707:
URL: https://github.com/apache/iceberg/issues/13707#issuecomment-4654902765
This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [epic] add all features of the IRC spec to the IRC reference implementation [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #13707:
URL: https://github.com/apache/iceberg/issues/13707#issuecomment-4774489699
This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [epic] add all features of the IRC spec to the IRC reference implementation [iceberg]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on issue #13707:
URL: https://github.com/apache/iceberg/issues/13707#issuecomment-3138074818
Thanks @kevinjqliu for filing this. Do we also know how much engines support Http etag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [epic] add all features of the IRC spec to the IRC reference implementation [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on issue #13707:
URL: https://github.com/apache/iceberg/issues/13707#issuecomment-3138219710
https://github.com/apache/iceberg/commits/main/open-api/rest-catalog-open-api.yaml
This gives us a view of all the recent changes to the IRC spec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [epic] add all features of the IRC spec to the IRC reference implementation [iceberg]
Posted by "gaborkaszab (via GitHub)" <gi...@apache.org>.
gaborkaszab commented on issue #13707:
URL: https://github.com/apache/iceberg/issues/13707#issuecomment-3275467654
I think I found another missing feature: The reference IRC doesn't send 204, however there are some endpoints where it could be possible, like the tableExists and some others. As I see the implementation either sends a non-2xx error code or 200-OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [epic] add all features of the IRC spec to the IRC reference implementation [iceberg]
Posted by "gaborkaszab (via GitHub)" <gi...@apache.org>.
gaborkaszab commented on issue #13707:
URL: https://github.com/apache/iceberg/issues/13707#issuecomment-3143685949
Hi @flyrain and @kevinjqliu ,
I added the HTTP ETag functionality to the REST spec and also started working on the implementation but then I got sidetracked a bit. I resumed the work just recently, and I have a [WiP PR](https://github.com/apache/iceberg/pull/12194) to take care of some prerequisites of returning response headers. On that PR we can discuss how to populate the opaque ETag that we attach to the response as an HTTP header. Once this is complete, I can move on to the freshness-aware loading part.
Any reviews are appreciated!
@kevinjqliu Should we document this functionality somehow as a gap between spec and the reference implementation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [epic] add all features of the IRC spec to the IRC reference implementation [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on issue #13707:
URL: https://github.com/apache/iceberg/issues/13707#issuecomment-3247613225
Thanks @gaborkaszab you're right! I added it to the missing features section, cheers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [epic] add all features of the IRC spec to the IRC reference implementation [iceberg]
Posted by "gaborkaszab (via GitHub)" <gi...@apache.org>.
gaborkaszab commented on issue #13707:
URL: https://github.com/apache/iceberg/issues/13707#issuecomment-3245051882
While browsing code and tests for REST catalog, I think that the reference implementation doesn't have the SNAPSHOTS.REFS mode just the SNAPSHOTS.ALL. I'm not sure if this is intentional, but seems missing. If this is in fact the case, we can add to this list and I volunteer to take care of it later on.
cc @kevinjqliu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [epic] add all features of the IRC spec to the IRC reference implementation [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #13707: [epic] add all features of the IRC spec to the IRC reference implementation
URL: https://github.com/apache/iceberg/issues/13707
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org