You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/01/06 12:25:36 UTC
[GitHub] [shardingsphere] codecov-io commented on pull request #8898: Refactor SingleTableRoutingEngine

codecov-io commented on pull request #8898:
URL: https://github.com/apache/shardingsphere/pull/8898#issuecomment-755270641


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8898?src=pr&el=h1) Report
   > Merging [#8898](https://codecov.io/gh/apache/shardingsphere/pull/8898?src=pr&el=desc) (a0b9a4a) into [master](https://codecov.io/gh/apache/shardingsphere/commit/7bcb0b117e6fd4ff44da4d948563e878545e94ca?el=desc) (7bcb0b1) will **increase** coverage by `0.41%`.
   > The diff coverage is `94.44%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/8898/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/8898?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #8898      +/-   ##
   ============================================
   + Coverage     69.64%   70.06%   +0.41%     
   - Complexity      625      647      +22     
   ============================================
     Files          1617     1638      +21     
     Lines         25841    25985     +144     
     Branches       4494     4495       +1     
   ============================================
   + Hits          17998    18207     +209     
   + Misses         6638     6566      -72     
   - Partials       1205     1212       +7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8898?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...e/engine/type/single/SingleTableRoutingEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/8898/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS90eXBlL3NpbmdsZS9TaW5nbGVUYWJsZVJvdXRpbmdFbmdpbmUuamF2YQ==) | `91.30% <94.44%> (+37.45%)` | `0.00 <0.00> (ø)` | |
   | [...agent/core/config/yaml/YamlAgentConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/8898/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jb25maWcveWFtbC9ZYW1sQWdlbnRDb25maWd1cmF0aW9uLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...gent/core/config/yaml/YamlPluginConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/8898/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jb25maWcveWFtbC9ZYW1sUGx1Z2luQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...t/core/config/loader/AgentConfigurationLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/8898/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jb25maWcvbG9hZGVyL0FnZW50Q29uZmlndXJhdGlvbkxvYWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...ore/config/yaml/YamlRemotePluginConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/8898/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jb25maWcveWFtbC9ZYW1sUmVtb3RlUGx1Z2luQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...ig/yaml/swapper/YamlAgentConfigurationSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/8898/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jb25maWcveWFtbC9zd2FwcGVyL1lhbWxBZ2VudENvbmZpZ3VyYXRpb25Td2FwcGVyLmphdmE=) | `0.00% <0.00%> (-92.86%)` | `0.00% <0.00%> (ø%)` | |
   | [...here/agent/core/config/yaml/engine/YamlEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/8898/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jb25maWcveWFtbC9lbmdpbmUvWWFtbEVuZ2luZS5qYXZh) | `0.00% <0.00%> (-80.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...ob/preparer/checker/AbstractDataSourceChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/8898/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvcHJlcGFyZXIvY2hlY2tlci9BYnN0cmFjdERhdGFTb3VyY2VDaGVja2VyLmphdmE=) | `34.78% <0.00%> (-65.22%)` | `1.00% <0.00%> (ø%)` | |
   | [...phere/agent/core/config/path/AgentPathBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/8898/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jb25maWcvcGF0aC9BZ2VudFBhdGhCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-54.17%)` | `0.00% <0.00%> (ø%)` | |
   | [...ere/scaling/core/utils/RdbmsConfigurationUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/8898/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS91dGlscy9SZGJtc0NvbmZpZ3VyYXRpb25VdGlsLmphdmE=) | `40.00% <0.00%> (-40.00%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [92 more](https://codecov.io/gh/apache/shardingsphere/pull/8898/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8898?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8898?src=pr&el=footer). Last update [7bcb0b1...a0b9a4a](https://codecov.io/gh/apache/shardingsphere/pull/8898?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org